Differential D6398

Use BlockHash for vInventoryBlockToSend
ClosedPublic
Actions

Authored by deadalnix on Jun 5 2020, 23:02.

Details

Reviewers

nakihito

Group Reviewers

Restricted Project

Commits

rABC0d451576ca38: Use BlockHash for vInventoryBlockToSend

Summary

This is the proper type.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

vInventoryBlockToSendBlockHash

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11244
Build 21215: Default Diff Build & Tests
Build 21214: Build without Wallet
Build 21213: Build with clang-10
Build 21212: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 5 2020, 23:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2020, 23:02

deadalnix requested review of this revision.Jun 5 2020, 23:02

Harbormaster completed remote builds in B11244: Diff 20970.Jun 5 2020, 23:12

deadalnix added a child revision: D6400: [refactor] Move tx relay state to separate structure.Jun 5 2020, 23:30

nakihito accepted this revision.Jun 6 2020, 00:45

This revision is now accepted and ready to land.Jun 6 2020, 00:45

Closed by commit rABC0d451576ca38: Use BlockHash for vInventoryBlockToSend (authored by deadalnix). · Explain WhyJun 6 2020, 10:38

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC0d451576ca38: Use BlockHash for vInventoryBlockToSend.

Revision Contents
Changeset List

Path

Size

src/

net.h

5 lines

net_processing.cpp

2 lines

Diff 20970

View Options

src/net.h