Differential D6764

refactor: Make scheduler methods type safe
ClosedPublic
Actions

Authored by Fabien on Jun 29 2020, 11:34.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCed2f9c673fdd: refactor: Make scheduler methods type safe

Summary

Backport of core PR18289.

This diff extends the original PR a bit due to avalanche.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR18289

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11761
Build 23102: Default Diff Build & Tests	Link to the build
Build 23101: Build without Wallet	Link to the build
Build 23100: Build with clang-10	Link to the build
Build 23099: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 29 2020, 11:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2020, 11:34

Fabien requested review of this revision.Jun 29 2020, 11:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Jun 29 2020, 11:58

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/scheduler.h
30	Clearly, this needs to be reformated properly.

This revision now requires changes to proceed.Jun 29 2020, 11:58

Harbormaster completed remote builds in B11761: Diff 21844.Jun 29 2020, 12:13

Relayout the usage comment

Harbormaster completed remote builds in B11763: Diff 21846.Jun 29 2020, 12:34

deadalnix accepted this revision.Jun 29 2020, 12:37

This revision is now accepted and ready to land.Jun 29 2020, 12:37

Closed by commit rABCed2f9c673fdd: refactor: Make scheduler methods type safe (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJun 29 2020, 13:07

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCed2f9c673fdd: refactor: Make scheduler methods type safe.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

3 lines

3 lines

3 lines

4 lines

7 lines

6 lines

2 lines

33 lines

24 lines

test/

scheduler_tests.cpp

19 lines

wallet/

load.cpp

4 lines

Diff 21844

View Options

src/avalanche/avalanche.cpp

View Options

src/banman.h

View Options

src/eventloop.h

View Options

src/eventloop.cpp

View Options

src/init.cpp

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

src/scheduler.h

View Options

src/scheduler.cpp

View Options

src/test/scheduler_tests.cpp

View Options

refactor: Make scheduler methods type safeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21844

src/avalanche/avalanche.cpp

src/banman.h

src/eventloop.h

src/eventloop.cpp

src/init.cpp

src/net.cpp

src/net_processing.cpp

src/scheduler.h

src/scheduler.cpp

src/test/scheduler_tests.cpp

src/wallet/load.cpp

refactor: Make scheduler methods type safe
ClosedPublic
Actions

Revision Contents
Changeset List