Page MenuHomePhabricator
Differential D7344

[backport#16404] qa: Test ZMQ notification after chain reorg
ClosedPublic
Actions

Authored by majcosta on Sep 3 2020, 19:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC14653a00bd9b: [backport#16404] qa: Test ZMQ notification after chain reorg
Summary

https://github.com/bitcoin/bitcoin/pull/16404/commits/abdfc5e89b687f73de4ab97e924c29cc27e71c15

Depends on D7343

Concludes backport of Core PR16404 and PR16740 (PR16404 on its own is broken and will not pass the tests otherwise, sorry)

notes:

* ditto as the note for D7343 re: callsite of socket.connect(address)

Test Plan
./test/functional/test_runner.py interface_zmq

Diff Detail

Event Timeline

majcosta created this revision.Sep 3 2020, 19:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2020, 19:05
majcosta requested review of this revision.Sep 3 2020, 19:05
teamcity edited the summary of this revision. (Show Details)Sep 3 2020, 19:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta mentioned this in D7341: [backport#16598] test: Remove confusing hash256 function in util.Sep 3 2020, 19:06
majcosta added a child revision: D7341: [backport#16598] test: Remove confusing hash256 function in util.Sep 3 2020, 19:07
Harbormaster completed remote builds in B12594: Diff 23248.Sep 3 2020, 19:42
majcosta updated this revision to Diff 23263.Sep 3 2020, 21:18

added the entirety of PR16740

majcosta edited the summary of this revision. (Show Details)Sep 3 2020, 21:19
majcosta edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B12605: Diff 23263.Sep 3 2020, 21:30
deadalnix accepted this revision.Sep 3 2020, 21:33
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/interface_zmq.py
146

jimcarreyvomit

This revision is now accepted and ready to land.Sep 3 2020, 21:33
Closed by commit rABC14653a00bd9b: [backport#16404] qa: Test ZMQ notification after chain reorg (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhySep 3 2020, 21:37
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC14653a00bd9b: [backport#16404] qa: Test ZMQ notification after chain reorg.

Revision Contents
Changeset List

PathSize
test/
functional/
32 lines

Diff 23263

View Options

test/functional/interface_zmq.py

Loading...