Differential D7866

wallet refactor: Avoid use of Chain::Lock in qt wallettests
ClosedPublic
Actions

Authored by deadalnix on Oct 10 2020, 23:20.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC06409d3c3413: wallet refactor: Avoid use of Chain::Lock in qt wallettests

Summary

This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

This change doesn't affect behavior.

This is part [3/12] of Core PR17954 : https://github.com/bitcoin/bitcoin/pull/17954/commits/ade5f87971211bc67753f14a0d49e020142efc7c

Depends on D7865

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17954-3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13337
Build 26713: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 26712: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 10 2020, 23:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2020, 23:20

deadalnix requested review of this revision.Oct 10 2020, 23:20

teamcity edited the summary of this revision. (Show Details)Oct 10 2020, 23:20

deadalnix edited the summary of this revision. (Show Details)Oct 10 2020, 23:21

deadalnix added a child revision: D7867: wallet: Avoid use of Chain::Lock in importprunedfunds.Oct 10 2020, 23:22

Harbormaster completed remote builds in B13337: Diff 24514.Oct 10 2020, 23:35

Fabien accepted this revision.Oct 11 2020, 10:07

This revision is now accepted and ready to land.Oct 11 2020, 10:07

Closed by commit rABC06409d3c3413: wallet refactor: Avoid use of Chain::Lock in qt wallettests (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyOct 11 2020, 12:23

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC06409d3c3413: wallet refactor: Avoid use of Chain::Lock in qt wallettests.

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

wallettests.cpp

5 lines

Diff 24514

View Options

src/qt/test/wallettests.cpp

wallet refactor: Avoid use of Chain::Lock in qt wallettestsClosedPublicActions