Differential D7871

wallet refactor: Avoid use of Chain::Lock in CWallet::RescanFromTime
ClosedPublic
Actions

Authored by deadalnix on Oct 10 2020, 23:46.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCcdad5a5b727d: wallet refactor: Avoid use of Chain::Lock in CWallet::RescanFromTime

Summary

This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

This change has no effect on behavior.

This is part [8/12] of Core PR17954 : https://github.com/bitcoin/bitcoin/pull/17954/commits/3cb85ac594f115db99f96b0a0f4bfdcd69ef0590

Depends on D7870

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17954-8

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13342
Build 26723: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang · build-diff · build-clang-tidy
Build 26722: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 10 2020, 23:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2020, 23:46

deadalnix requested review of this revision.Oct 10 2020, 23:46

teamcity edited the summary of this revision. (Show Details)Oct 10 2020, 23:46

deadalnix added a child revision: D7872: wallet: Avoid use of Chain::Lock in rescanblockchain.Oct 10 2020, 23:48

Harbormaster completed remote builds in B13342: Diff 24519.Oct 10 2020, 23:56

Fabien accepted this revision.Oct 11 2020, 10:21

This revision is now accepted and ready to land.Oct 11 2020, 10:21

Closed by commit rABCcdad5a5b727d: wallet refactor: Avoid use of Chain::Lock in CWallet::RescanFromTime (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyOct 11 2020, 12:31

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCcdad5a5b727d: wallet refactor: Avoid use of Chain::Lock in CWallet::RescanFromTime.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

chain.h

8 lines

chain.cpp

7 lines

test/

interfaces_tests.cpp

15 lines

wallet/

wallet.cpp

22 lines

Diff 24519

View Options

src/interfaces/chain.h

View Options

src/interfaces/chain.cpp

View Options

src/test/interfaces_tests.cpp

View Options

wallet refactor: Avoid use of Chain::Lock in CWallet::RescanFromTimeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24519

src/interfaces/chain.h

src/interfaces/chain.cpp

src/test/interfaces_tests.cpp

src/wallet/wallet.cpp

wallet refactor: Avoid use of Chain::Lock in CWallet::RescanFromTime
ClosedPublic
Actions

Revision Contents
Changeset List