Page MenuHomePhabricator
Differential D9077

Disable CWalletTx copy constructor
ClosedPublic
Actions

Authored by PiRK on Jan 27 2021, 10:16.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC19dfc4927677: Disable CWalletTx copy constructor
Summary

Disable copying of CWalletTx objects to prevent bugs where instances get copied
in and out of the mapWallet map and fields are updated in the wrong copy.

This is a backport of Core PR9381 [4/5]
https://github.com/bitcoin/bitcoin/pull/9381/commits/d002f9d15d938e78360ad906f2d74a249c7e923e
Depends on D9076

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Jan 27 2021, 10:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2021, 10:16
PiRK requested review of this revision.Jan 27 2021, 10:16
teamcity edited the summary of this revision. (Show Details)Jan 27 2021, 10:16
PiRK added a child revision: D9078: Get rid of BindWallet.Jan 27 2021, 10:17
Harbormaster completed remote builds in B15009: Diff 27353.Jan 27 2021, 10:36
majcosta accepted this revision.Jan 27 2021, 15:06
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/wallet/test/psbt_wallet_tests.cpp
46 ↗(On Diff #27353)

remove pls

This revision is now accepted and ready to land.Jan 27 2021, 15:06
PiRK updated this revision to Diff 27359.Jan 27 2021, 15:49

remove spurious blank line

Harbormaster completed remote builds in B15015: Diff 27359.Jan 27 2021, 16:03
Closed by commit rABC19dfc4927677: Disable CWalletTx copy constructor (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyJan 27 2021, 16:42
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC19dfc4927677: Disable CWalletTx copy constructor.

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
test/
10 lines
8 lines
4 lines
5 lines
13 lines

Diff 27359

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/psbt_wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...