Page MenuHomePhabricator
Differential D1012

Use non-atomic flushing with block replay
ClosedPublic
Actions

Authored by deadalnix on Jan 22 2018, 19:00.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGdd72e5e0e470: Use non-atomic flushing with block replay
rABCdd72e5e0e470: Use non-atomic flushing with block replay
Summary

Backport core's PR10148

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 22 2018, 19:00
Harbormaster completed remote builds in B1723: Diff 2678.Jan 22 2018, 19:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2018, 19:00
Herald added a reviewer: Restricted Project. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 22 2018, 19:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 22 2018, 19:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel accepted this revision.Jan 25 2018, 03:58
schancel added a subscriber: schancel.
schancel added inline comments.
src/txdb.cpp
122 ↗(On Diff #2678)

I'm not at all a fan of this being included here. I'd much rather the test framework kill -9'd the process repeatedly and take longer to run.

This revision is now accepted and ready to land.Jan 25 2018, 03:58
deadalnix added inline comments.Jan 25 2018, 15:01
src/txdb.cpp
122 ↗(On Diff #2678)

Agreed.

Closed by commit rABCdd72e5e0e470: Use non-atomic flushing with block replay (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyJan 25 2018, 15:47
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
contrib/
devtools/
2 lines
src/
5 lines
22 lines
16 lines
18 lines
18 lines
24 lines
9 lines
54 lines
5 lines
167 lines
test/
functional/
305 lines
test_framework/
5 lines
1 line

Diff 2736

View Options

contrib/devtools/check-doc.py

Loading...
View Options

src/chain.h

Loading...
View Options

src/chain.cpp

Loading...
View Options

src/coins.h

Loading...
View Options

src/coins.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/txdb.h

Loading...
View Options

src/txdb.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/dbcrash.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...
View Options

test/functional/test_runner.py

Loading...