Differential D9492

[avalanche] Add a sendavalancheproof RPC shell
ClosedPublic
Actions

Authored by Fabien on May 10 2021, 13:35.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC2e4bc27105b7: [avalanche] Add a sendavalancheproof RPC shell

Summary

This adds a new sendavalancheproof RPC which takes a proof, validates
it, adds it to the pool if not known already and announces it via a
proof inventory message.

Sending the inventory message needs some code in the network layer,
which itself cannot be tested without a RPC to trigger it. This is the
reason why this RPC does not send the proof yet. This will be added in a
follow up diff for ease of review.

This diff contains all the tooling and tests to make it very easy to
complete the RPC once done.

Depends on D9648.

Ref T1611.

Test Plan

./test/functional/test_runner.py abc_rpc_avalancheproof

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_sendproof_rpc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15672
Build 31248: Build Diff	lint-circular-dependencies · build-clang-tidy · build-without-wallet · build-diff · build-debug · build-clang
Build 31247: arc lint + arc unit

Event Timeline

Fabien created this revision.May 10 2021, 13:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 10 2021, 13:35

Fabien requested review of this revision.May 10 2021, 13:35

Harbormaster completed remote builds in B15670: Diff 28402.May 10 2021, 13:35

Fabien added a child revision: D9493: [avalanche] Prevent sending proof invs multiple times to the same peer.May 10 2021, 14:33

Fabien planned changes to this revision.May 10 2021, 14:46

Fix the build with no wallet

Harbormaster completed remote builds in B15672: Diff 28405.May 10 2021, 15:02

This is doing several thing at once. What about starting with a validateproof RPC?

src/net_processing.cpp
1784	IIRC, this send only thing to outbound peers, no? Is that the set of peer that is desired? Maybe that is fine for now.
src/net_processing.h
19	I don't think the semicolon is needed.

This revision now requires changes to proceed.May 10 2021, 15:54

Mengerian added a task: Restricted Maniphest Task.May 21 2021, 15:58

Fabien planned changes to this revision.Jun 4 2021, 19:58

Fabien retitled this revision from [avalanche] Add a sendavalancheproof RPC to broadcast a proof to [avalanche] Add a sendavalancheproof RPC shell.Jun 8 2021, 15:04

Fabien edited the summary of this revision. (Show Details)

Fabien edited the test plan for this revision. (Show Details)

Fabien added a parent revision: D9648: [avalanche] Add a facility to check if avalanche is enabled.

Rebase on top of D9648, make it an empty shell for now

Harbormaster completed remote builds in B15942: Diff 28809.Jun 8 2021, 15:19

Fabien added a child revision: D9650: [avalanche] Send proof inventories.Jun 8 2021, 15:19

deadalnix accepted this revision.Jun 8 2021, 15:29

This revision is now accepted and ready to land.Jun 8 2021, 15:29

Fabien removed a parent revision: D9489: [avalanche] Annouce our proofs to our peers.Jun 9 2021, 07:53

Closed by commit rABC2e4bc27105b7: [avalanche] Add a sendavalancheproof RPC shell (authored by Fabien). · Explain WhyJun 9 2021, 07:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2e4bc27105b7: [avalanche] Add a sendavalancheproof RPC shell.