Differential D9503

[net processing] Remove mempool argument from AlreadyHaveBlock()
ClosedPublic
Actions

Authored by Fabien on May 12 2021, 13:26.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC63d5b8764b4a: [net processing] Remove mempool argument from AlreadyHaveBlock()

Summary

Partial backport of core#19610:
https://github.com/bitcoin/bitcoin/pull/19610/commits/430e183b89d00b4148f0b77a6fcacca2cd948202

Depends on D9502.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19610_p3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15690
Build 31284: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 31283: arc lint + arc unit

Event Timeline

Fabien created this revision.May 12 2021, 13:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2021, 13:26

Fabien requested review of this revision.May 12 2021, 13:26

teamcity edited the summary of this revision. (Show Details)May 12 2021, 13:26

Fabien added a child revision: D9504: [net processing] Change AlreadyHaveBlock() to take block_hash argument.May 12 2021, 13:33

Harbormaster completed remote builds in B15690: Diff 28429.May 12 2021, 13:38

majcosta accepted this revision.May 12 2021, 14:40

This revision is now accepted and ready to land.May 12 2021, 14:40

Closed by commit rABC63d5b8764b4a: [net processing] Remove mempool argument from AlreadyHaveBlock() (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyMay 12 2021, 19:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC63d5b8764b4a: [net processing] Remove mempool argument from AlreadyHaveBlock().

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

4 lines

Diff 28429

View Options

[net processing] Remove mempool argument from AlreadyHaveBlock()ClosedPublicActions