Differential D9502

[net processing] Split AlreadyHave() into separate block and tx functions
ClosedPublic
Actions

Authored by Fabien on May 12 2021, 13:19.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC1a1922529936: [net processing] Split AlreadyHave() into separate block and tx functions

Summary

Partial backport of core#19610:
https://github.com/bitcoin/bitcoin/pull/19610/commits/42ca5618cae0fd9ef97d2006b17d896bc58cc17c?diff=split&w=1

This will help narrowing the cs_main scope when introducing the proofs.
There are more simplifications and de-duplication to come in follow-up
backports.

Depends on D9501.

Note that the commit
https://github.com/bitcoin/bitcoin/pull/19610/commits/39f1dc944554218911b0945fff7e6d06f3dab284
is skipped because it is a segwit only commit.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 12 2021, 13:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2021, 13:19

Fabien requested review of this revision.May 12 2021, 13:19

teamcity edited the summary of this revision. (Show Details)May 12 2021, 13:19

Fabien added a child revision: D9503: [net processing] Remove mempool argument from AlreadyHaveBlock().May 12 2021, 13:26

Harbormaster completed remote builds in B15689: Diff 28428.May 12 2021, 13:31

Fix static bool vs bool static

majcosta accepted this revision.May 12 2021, 14:39

This revision is now accepted and ready to land.May 12 2021, 14:39

Harbormaster completed remote builds in B15696: Diff 28435.May 12 2021, 14:44

Closed by commit rABC1a1922529936: [net processing] Split AlreadyHave() into separate block and tx functions (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyMay 12 2021, 19:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1a1922529936: [net processing] Split AlreadyHave() into separate block and tx functions.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

81 lines

Diff 28443

View Options

[net processing] Split AlreadyHave() into separate block and tx functionsClosedPublicActions