Differential D1094

unit test for OP_DIV
AbandonedPublic
Actions

Authored by movrcx on Feb 15 2018, 00:54.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Unit tests for OP_DIV

Co-authored-by: Marcos Mayorga <mm@mm-studios.com>

Test Plan

N/A

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1846
Build 1879: arc lint + arc unit

Event Timeline

movrcx created this revision.Feb 15 2018, 00:54

Harbormaster completed remote builds in B1846: Diff 2869.Feb 15 2018, 00:54

movrcx added a parent revision: D1093: Adds OP_DIV functionality into interpreter.cpp.Feb 15 2018, 00:55

movrcx added a child revision: D1095: Adds OP_MOD functionality into interpreter.cpp.Feb 15 2018, 01:00

movrcx added a child revision: D1097: Add support for CAT, and SPLIT opcodes.Feb 15 2018, 01:04

movrcx added a child revision: D1099: Adds OP_SPLIT functionality into interpreter.cpp.Feb 15 2018, 01:15

movrcx added a child revision: D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.Feb 15 2018, 01:21

movrcx added a child revision: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.Feb 15 2018, 01:26

In C++ there is a corner-case where the maximal negative integer, divided by -1, overflows. Is there something similar in script?

movrcx edited the summary of this revision. (Show Details)Feb 15 2018, 02:40

In D1094#20090, @kyuupichan wrote:

In C++ there is a corner-case where the maximal negative integer, divided by -1, overflows. Is there something similar in script?

When the operands get loaded into CScriptNum they are allowed up to 4 bytes. They get allocated into an int64_t so there are no overflow issues. If the operation results in an overflow of the 4 bytes then the result gets pushed onto the stack but future arithmetic operations intentionally fail.

CScriptNum bn2(stacktop(-1), fRequireMinimal);

shadders added a subscriber: shadders.Feb 15 2018, 03:22

movrcx abandoned this revision.Feb 16 2018, 08:30

schancel removed a child revision: D1097: Add support for CAT, and SPLIT opcodes.Mar 9 2018, 10:48

schancel removed a child revision: D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.Mar 9 2018, 10:52

schancel removed a child revision: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.Mar 9 2018, 10:54

schancel removed a child revision: D1099: Adds OP_SPLIT functionality into interpreter.cpp.

schancel removed a child revision: D1095: Adds OP_MOD functionality into interpreter.cpp.

schancel removed a parent revision: D1093: Adds OP_DIV functionality into interpreter.cpp.Mar 9 2018, 10:58

Revision Contents
Changeset List

Path

Size

src/

test/

data/

script_tests.json

2 lines

op_code.cpp

461 lines

Diff 2869

View Options

src/test/data/script_tests.json