Page MenuHomePhabricator
Differential D1136

Move oversized checks to the message header class.
ClosedPublic
Actions

Authored by deadalnix on Feb 25 2018, 19:00.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Maniphest Tasks
T297: Allow for 32 Megabyte blocks
Commits
rSTAGINGe63f5fbee507: Move oversized checks to the message header class.
rABCe63f5fbee507: Move oversized checks to the message header class.
Summary

This moves the size check in the CMessageHeader class.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
checkoversizedmessage
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1934
Build 2026: Bitcoin ABC Buildbot (legacy)
Build 2025: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 25 2018, 19:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 25 2018, 19:00
teamcity added a subscriber: teamcity.Feb 25 2018, 19:02

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 25 2018, 19:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1933: Diff 2983.Feb 25 2018, 19:24
deadalnix updated this revision to Diff 2985.Feb 25 2018, 19:56

Update the full block test to reflect the change

teamcity added a comment.Feb 25 2018, 19:56

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix added a child revision: D1137: Use a fixed size integer to track the number of bytes is various parts of the network code..Feb 25 2018, 20:01
teamcity added a comment.Feb 25 2018, 20:17

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1934: Diff 2985.Feb 25 2018, 20:17
jasonbcox accepted this revision.Feb 25 2018, 20:58
jasonbcox added a subscriber: jasonbcox.

LGTM

This revision is now accepted and ready to land.Feb 25 2018, 20:58
deadalnix added a parent revision: D1133: Accept network messages for 32MB blocks and larger..Feb 25 2018, 21:08
Closed by commit rABCe63f5fbee507: Move oversized checks to the message header class. (authored by deadalnix). · Explain WhyFeb 26 2018, 16:53
This revision was automatically updated to reflect the committed changes.
schancel added a task: T297: Allow for 32 Megabyte blocks.Mar 15 2018, 14:52

Revision Contents
Changeset List

PathSize
src/
7 lines
24 lines
2 lines
12 lines
71 lines
seeder/
2 lines
test/
2 lines
test/
functional/
2 lines

Diff 2985

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/protocol.h

Loading...
View Options

src/protocol.cpp

Loading...
View Options

src/seeder/bitcoin.cpp

Loading...
View Options

src/test/test_bitcoin_fuzzy.cpp

Loading...
View Options

test/functional/abc-p2p-fullblocktest.py

Loading...