Page MenuHomePhabricator
Differential D10226

refactor: Use DatabaseStatus and DatabaseOptions types
ClosedPublic
Actions

Authored by PiRK on Sep 30 2021, 13:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC97efc9047ebf: refactor: Use DatabaseStatus and DatabaseOptions types
Summary

No changes in behavior. Just replaces arguments and return types

This is a backport of core#19619 [3/8]
https://github.com/bitcoin/bitcoin/pull/19619/commits/0d94e6062547f288a75921d2433458a44a5f2297

Depends on D10225

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Sep 30 2021, 13:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2021, 13:31
PiRK requested review of this revision.Sep 30 2021, 13:31
teamcity edited the summary of this revision. (Show Details)Sep 30 2021, 13:32
PiRK added a child revision: D10227: wallet: Remove Verify and IsLoaded methods.Sep 30 2021, 13:33
Harbormaster completed remote builds in B16832: Diff 30236.Sep 30 2021, 13:56
Fabien requested changes to this revision.Sep 30 2021, 20:58
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
347 ↗(On Diff #30236)

Don't remove the error message. Also this is a hint that there is no test for this message.

This revision now requires changes to proceed.Sep 30 2021, 20:58
PiRK updated this revision to Diff 30265.Oct 1 2021, 06:58

add the error message that was accidentaly removed.i

I try to will look into adding the missing test, if it is possible at all to reach this branch.

Harbormaster completed remote builds in B16853: Diff 30265.Oct 1 2021, 07:12
Fabien accepted this revision.Oct 1 2021, 08:12
This revision is now accepted and ready to land.Oct 1 2021, 08:12
Closed by commit rABC97efc9047ebf: refactor: Use DatabaseStatus and DatabaseOptions types (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyOct 5 2021, 08:48
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC97efc9047ebf: refactor: Use DatabaseStatus and DatabaseOptions types.

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
23 lines
qt/
8 lines
wallet/
5 lines
30 lines
23 lines
58 lines

Diff 30265

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/walletcontroller.cpp

Loading...
View Options

src/wallet/db.h

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...