Paths

Table of Contentst

Differential D10320

[refactor] clarify tests by referencing p2p objects directly
ClosedPublic
Actions

Authored by PiRK on Oct 13 2021, 07:16.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC53018ea73eb3: [refactor] clarify tests by referencing p2p objects directly

Summary

Use object returned from add_p2p_connection to refer to
p2ps. Add a test class attribute if it needs to be used across
many methods. Don't use the p2p property.

This is a backport of core#19804 [1a/4]
https://github.com/bitcoin/bitcoin/pull/19804/commits/784f757994c1306bb6584b14c0c78617d6248432

abc* test will be done separately.

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16988
Build 33812: Build Diff	build-clang · build-debug · build-without-wallet · build-diff · build-clang-tidy
Build 33811: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 13 2021, 07:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 13 2021, 07:16

PiRK requested review of this revision.Oct 13 2021, 07:16

teamcity edited the summary of this revision. (Show Details)Oct 13 2021, 07:16

Harbormaster completed remote builds in B16988: Diff 30478.Oct 13 2021, 08:24

PiRK added a child revision: D10325: [test] remove confusing p2p property.Oct 13 2021, 08:33

That's not the right commit

This revision now requires changes to proceed.Oct 13 2021, 12:46

Fixed commit in the description

Fabien accepted this revision.Oct 13 2021, 15:43

This revision is now accepted and ready to land.Oct 13 2021, 15:43

Closed by commit rABC53018ea73eb3: [refactor] clarify tests by referencing p2p objects directly (authored by gzhao408 <gzhao408@berkeley.edu>, committed by PiRK). · Explain WhyOct 14 2021, 11:47

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC53018ea73eb3: [refactor] clarify tests by referencing p2p objects directly.

Revision Contents
Changeset List

Path

Size

test/

functional/

example_test.py

14 lines

feature_block.py

8 lines

feature_cltv.py

18 lines

feature_csv_activation.py

4 lines

feature_dersig.py

12 lines

feature_maxuploadtarget.py

8 lines

mempool_packages.py

4 lines

mining_basic.py

6 lines

p2p_blocksonly.py

10 lines

p2p_dos_header_tree.py

18 lines

2 lines

p2p_invalid_block.py

18 lines

p2p_invalid_locator.py

16 lines

rpc_blockchain.py

4 lines

wallet_resendwallettransactions.py

8 lines

Diff 30478

test/functional/example_test.py

Loading...

test/functional/feature_block.py

Loading...

test/functional/feature_cltv.py

Loading...

test/functional/feature_csv_activation.py

Loading...

test/functional/feature_dersig.py

Loading...

test/functional/feature_maxuploadtarget.py

Loading...

test/functional/mempool_packages.py

Loading...

test/functional/mining_basic.py

Loading...

test/functional/p2p_blocksonly.py

Loading...

test/functional/p2p_dos_header_tree.py

Loading...

test/functional/p2p_filter.py

Loading...

test/functional/p2p_invalid_block.py

Loading...

test/functional/p2p_invalid_locator.py

Loading...

test/functional/rpc_blockchain.py

Loading...

test/functional/wallet_resendwallettransactions.py

Loading...