Page MenuHomePhabricator
Differential D1178

Backport various improvement to test_framework.py
ClosedPublic
Actions

Authored by deadalnix on Mar 6 2018, 10:36.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING90b86ad1ddfb: Backport various improvement to test_framework.py
rABC90b86ad1ddfb: Backport various improvement to test_framework.py
Summary

Backport several PRs and commits, plus fix a few nits.

PR #10318: [tests] fix wait_for_inv()

3e3c22f [tests] fix wait_for_inv() (John Newbery)

PR #10124: [test] Suppress test logging spam

45ce471 Reduce spammy test logging (John Newbery)

Commit a7820422e (Part of PR #11319)

qa: Treat mininode p2p exceptions as fatal (Suhas Daftuar)
Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mininodemodernize
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2023
Build 2194: Bitcoin ABC Buildbot (legacy)
Build 2193: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 6 2018, 10:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2018, 10:36
deadalnix planned changes to this revision.Mar 6 2018, 10:41

This is broken.

teamcity added a subscriber: teamcity.Mar 6 2018, 11:13

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 6 2018, 11:35

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2013: Diff 3103!Mar 6 2018, 11:35
danconnolly added a subscriber: danconnolly.Mar 6 2018, 17:31
deadalnix updated this revision to Diff 3118.Mar 7 2018, 15:23

Backports introduced the same race condition that was fixed in D284 . Fixed again :)
Fix a bug in abc-p2p-compactblocks where the network thread is started twice.

teamcity added a comment.Mar 7 2018, 15:25

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix updated this revision to Diff 3119.Mar 7 2018, 15:31

Rebase and nit tweak some logs

teamcity added a comment.Mar 7 2018, 15:32

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2022: Diff 3118.Mar 7 2018, 15:42
teamcity added a comment.Mar 7 2018, 15:42

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2023: Diff 3119.Mar 7 2018, 15:50
teamcity added a comment.Mar 7 2018, 15:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel added a subscriber: schancel.Mar 7 2018, 19:04

This claims to include the same PR as https://reviews.bitcoinabc.org/D1183

schancel accepted this revision.Mar 7 2018, 19:07
schancel edited the summary of this revision. (Show Details)

Updated the description and removed reference to PR #11078

This revision is now accepted and ready to land.Mar 7 2018, 19:08
Closed by commit rABC90b86ad1ddfb: Backport various improvement to test_framework.py (authored by deadalnix). · Explain WhyMar 7 2018, 21:20
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
4 lines
test_framework/
83 lines

Diff 3119

View Options

test/functional/abc-p2p-compactblocks.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...