Page MenuHomePhabricator
Differential D10774

[avalanche] Use the proof registration state in net processing
ClosedPublic
Actions

Authored by Fabien on Jan 6 2022, 13:53.

Details

Reviewers
tyler-smith
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC216ecee51737: [avalanche] Use the proof registration state in net processing
Summary

This simplifies the logic when receiving an avalanche proof.

Ref T1854.

Depends on D10773.

Test Plan
ninja check-extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_registration_state_net_processing
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17873
Build 35572: Build Diffbuild-without-wallet · lint-circular-dependencies · build-clang-tidy · build-clang · build-debug · build-diff
Build 35571: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 6 2022, 13:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2022, 13:54
Fabien requested review of this revision.Jan 6 2022, 13:54
Harbormaster completed remote builds in B17806: Diff 31666.Jan 6 2022, 14:14
Fabien updated this revision to Diff 31744.Jan 11 2022, 08:35

Message change applies to an extended test

Fabien edited the summary of this revision. (Show Details)Jan 11 2022, 08:35
Fabien edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B17873: Diff 31744.Jan 11 2022, 08:47
Fabien updated this revision to Diff 31813.Jan 14 2022, 11:02

Rebase

Harbormaster completed remote builds in B17914: Diff 31813.Jan 14 2022, 11:29
tyler-smith accepted this revision.Jan 17 2022, 02:57
tyler-smith added a subscriber: tyler-smith.

I like this change; in particular, I think it's more understandable with the explicit check for the invalid state.

This revision is now accepted and ready to land.Jan 17 2022, 02:57
Closed by commit rABC216ecee51737: [avalanche] Use the proof registration state in net processing (authored by Fabien). · Explain WhyJan 31 2022, 18:01
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC216ecee51737: [avalanche] Use the proof registration state in net processing.

Revision Contents
Changeset List

PathSize
src/
19 lines
test/
functional/
2 lines

Diff 31744

View Options

src/net_processing.cpp

Loading...
View Options

test/functional/abc_p2p_proof_inventory.py

Loading...