Paths

Table of Contentst

Differential D11036

net, rpc: return NET_UNROUTABLE as not_publicly_routable, automate helps
ClosedPublic
Actions

Authored by PiRK on Feb 10 2022, 15:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe9e01caeb642: net, rpc: return NET_UNROUTABLE as not_publicly_routable, automate helps

Summary

net: update NET_UNROUTABLE to not_publicly_routable in GetNetworkName()

net: create GetNetworkNames()

rpc: use GetNetworkNames() in getnetworkinfo and getpeerinfo helps

init: use GetNetworkNames() in -onlynet help

This is a backport of core#20965

Depends on D11030

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18243
Build 36294: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 36293: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 10 2022, 15:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2022, 15:18

PiRK requested review of this revision.Feb 10 2022, 15:18

teamcity edited the summary of this revision. (Show Details)Feb 10 2022, 15:18

PiRK added a child revision: D11037: net: recognize I2P from ParseNetwork() so that -onlynet=i2p works, do not skip I2P in GetNetworkNames().Feb 10 2022, 15:20

Harbormaster completed remote builds in B18243: Diff 32336.Feb 10 2022, 15:37

Fabien accepted this revision.Feb 11 2022, 09:11

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/netaddress.h
39	Wow, this comment update is really a game changer.

This revision is now accepted and ready to land.Feb 11 2022, 09:11

Closed by commit rABCe9e01caeb642: net, rpc: return NET_UNROUTABLE as not_publicly_routable, automate helps (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyFeb 15 2022, 18:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe9e01caeb642: net, rpc: return NET_UNROUTABLE as not_publicly_routable, automate helps.

Revision Contents
Changeset List

Path

Size

src/

15 lines

2 lines

5 lines

18 lines

rpc/

net.cpp

8 lines

test/

functional/

feature_proxy.py

5 lines

rpc_net.py

10 lines

Diff 32336

View Options

src/init.cpp

View Options

src/netaddress.h

View Options

src/netbase.h

View Options

src/netbase.cpp

View Options

src/rpc/net.cpp

View Options

test/functional/feature_proxy.py

View Options

test/functional/rpc_net.py

net, rpc: return NET_UNROUTABLE as not_publicly_routable, automate helpsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32336

src/init.cpp

src/netaddress.h

src/netbase.h

src/netbase.cpp

src/rpc/net.cpp

test/functional/feature_proxy.py

test/functional/rpc_net.py

net, rpc: return NET_UNROUTABLE as not_publicly_routable, automate helps
ClosedPublic
Actions

Revision Contents
Changeset List