Page MenuHomePhabricator
Differential D1206

Update release files for 0.17.0
ClosedPublic
Actions

Authored by schancel on Mar 16 2018, 17:41.

Details

Reviewers
jasonbcox
Mengerian
matiu
movrcx
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T286: Release 0.17.0 Inclusions
Commits
rSTAGING2ebe90a5f470: Update release files for 0.17.0
rABC2ebe90a5f470: Update release files for 0.17.0
Summary

Following doc/release-process.md, update the files as per
instructions for release 0.17.0

Test Plan

Review files, build, and verify versioning

Diff Detail

Repository
rABC Bitcoin ABC
Branch
release-0-17-0
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2119
Build 2383: Bitcoin ABC Buildbot (legacy)
Build 2382: arc lint + arc unit

Event Timeline

schancel created this revision.Mar 16 2018, 17:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 16 2018, 17:41
teamcity added a subscriber: teamcity.Mar 16 2018, 17:41

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel updated this revision to Diff 3241.Mar 16 2018, 17:47

Fix newline at the end of the release notes

teamcity added a comment.Mar 16 2018, 17:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel updated this revision to Diff 3242.Mar 16 2018, 17:48

Fix gitian descriptors which failed to get included

schancel added a task: T286: Release 0.17.0 Inclusions.Mar 16 2018, 17:55
teamcity added a comment.Mar 16 2018, 17:57

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2119: Diff 3240!Mar 16 2018, 17:57
teamcity added a comment.Mar 16 2018, 17:57

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B2120: Diff 3241!Mar 16 2018, 18:03
teamcity added a comment.Mar 16 2018, 18:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

matiu added a comment.Mar 16 2018, 18:04

left some minor comments.

configure.ac
8 ↗(On Diff #3242)

2018?

doc/release-notes.md
11 ↗(On Diff #3242)

Add '(Tue May 15 12:00:00 UTC, 2018)

jasonbcox added inline comments.Mar 16 2018, 18:07
doc/release-notes.md
11 ↗(On Diff #3242)

We should make it clear that this is an estimate.

teamcity added a comment.Mar 16 2018, 18:12

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2121: Diff 3242!Mar 16 2018, 18:12
schancel marked 2 inline comments as done.Mar 16 2018, 18:29
schancel updated this revision to Diff 3243.Mar 16 2018, 18:30

Address comments from matiu

teamcity added a comment.Mar 16 2018, 18:30

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 16 2018, 18:48

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2122: Diff 3243!Mar 16 2018, 18:48
deadalnix added a subscriber: deadalnix.Mar 17 2018, 00:35

It's not in shape to be a RC, tbh.

deadalnix added inline comments.Mar 19 2018, 09:59
doc/release-notes.md
15 ↗(On Diff #3243)

They'll be added in there once implemented.

deadalnix requested changes to this revision.Apr 1 2018, 15:03
deadalnix added inline comments.
configure.ac
6 ↗(On Diff #3243)

Why is build 1 ?

7 ↗(On Diff #3243)

Let's keep that one to true. We'll eventually get to use it when we branch out, but right now we don't have the kind of volume that justify maintaining several branches.

doc/release-notes.md
3 ↗(On Diff #3243)

Let's keep the release notes related to the release.

10 ↗(On Diff #3243)

This needs to be done.

src/clientversion.h
21 ↗(On Diff #3243)

Why is build 1 ? We don't really use build and show it nowhere so far.

src/qt/intro.cpp
26 ↗(On Diff #3243)

We should have a diff that updates all parameters (minwork, assumevalid, etc...)

This revision now requires changes to proceed.Apr 1 2018, 15:03
schancel updated this revision to Diff 3367.Apr 1 2018, 21:15

Updated based on feedback, rebased, changelog still needs to be updated.

schancel retitled this revision from Update release files for 0.17.0rc1 to Update release files for 0.17.0.Apr 1 2018, 21:16
jasonbcox accepted this revision.Apr 1 2018, 21:20

LGTM

teamcity added a comment.Apr 1 2018, 21:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 1 2018, 21:37

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 1 2018, 21:54

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2222: Diff 3367.Apr 1 2018, 21:54
schancel updated this revision to Diff 3369.Apr 2 2018, 01:00
schancel marked an inline comment as done.

Update release notes to include other relevant changes

jasonbcox accepted this revision.Apr 2 2018, 01:02
teamcity added a comment.Apr 2 2018, 01:02

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel updated this revision to Diff 3370.Apr 2 2018, 01:21

Add note about replay protection.

teamcity added a comment.Apr 2 2018, 01:22

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Apr 2 2018, 01:22

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2223: Diff 3369.Apr 2 2018, 01:22
schancel edited the summary of this revision. (Show Details)Apr 2 2018, 01:34
teamcity added a comment.Apr 2 2018, 01:35

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2224: Diff 3370.Apr 2 2018, 01:52
teamcity added a comment.Apr 2 2018, 01:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix accepted this revision.Apr 2 2018, 12:49
This revision is now accepted and ready to land.Apr 2 2018, 12:49
schancel updated this revision to Diff 3371.Apr 2 2018, 16:02

Remove note about future replay protection

teamcity added a comment.Apr 2 2018, 16:06

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Closed by commit rABC2ebe90a5f470: Update release files for 0.17.0 (authored by schancel). · Explain WhyApr 2 2018, 16:25
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Apr 2 2018, 16:25

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2225: Diff 3371.Apr 2 2018, 16:26

Revision Contents
Changeset List

PathSize
8 lines
contrib/
gitian-descriptors/
2 lines
doc/
2 lines
11 lines
src/
2 lines
6 lines
qt/
4 lines
test/
2 lines

Diff 3240

View Options

configure.ac

Loading...
View Options

contrib/gitian-descriptors/gitian-win.yml

Loading...
View Options

doc/Doxyfile

Loading...
View Options

doc/release-notes.md

Loading...
View Options

src/chainparams.cpp

Loading...
View Options

src/clientversion.h

Loading...
View Options

src/qt/intro.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...