Page MenuHomePhabricator

Update release files for 0.17.0
ClosedPublic

Authored by schancel on Mar 16 2018, 17:41.

Details

Summary

Following doc/release-process.md, update the files as per
instructions for release 0.17.0

Test Plan

Review files, build, and verify versioning

Diff Detail

Repository
rABC Bitcoin ABC
Branch
release-0-17-0
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2224
Build 2591: Bitcoin ABC Buildbot (legacy)
Build 2590: arc lint + arc unit

Event Timeline

Fix newline at the end of the release notes

Fix gitian descriptors which failed to get included

left some minor comments.

configure.ac
8 ↗(On Diff #3242)

2018?

doc/release-notes.md
11 ↗(On Diff #3242)

Add '(Tue May 15 12:00:00 UTC, 2018)

doc/release-notes.md
11 ↗(On Diff #3242)

We should make it clear that this is an estimate.

Address comments from matiu

It's not in shape to be a RC, tbh.

doc/release-notes.md
15 ↗(On Diff #3243)

They'll be added in there once implemented.

deadalnix requested changes to this revision.Apr 1 2018, 15:03
deadalnix added inline comments.
configure.ac
6 ↗(On Diff #3243)

Why is build 1 ?

7 ↗(On Diff #3243)

Let's keep that one to true. We'll eventually get to use it when we branch out, but right now we don't have the kind of volume that justify maintaining several branches.

doc/release-notes.md
3 ↗(On Diff #3243)

Let's keep the release notes related to the release.

10 ↗(On Diff #3243)

This needs to be done.

src/clientversion.h
21 ↗(On Diff #3243)

Why is build 1 ? We don't really use build and show it nowhere so far.

src/qt/intro.cpp
26 ↗(On Diff #3243)

We should have a diff that updates all parameters (minwork, assumevalid, etc...)

This revision now requires changes to proceed.Apr 1 2018, 15:03

Updated based on feedback, rebased, changelog still needs to be updated.

schancel retitled this revision from Update release files for 0.17.0rc1 to Update release files for 0.17.0.Apr 1 2018, 21:16
schancel marked an inline comment as done.

Update release notes to include other relevant changes

Add note about replay protection.

This revision is now accepted and ready to land.Apr 2 2018, 12:49

Remove note about future replay protection

This revision was automatically updated to reflect the committed changes.