Differential D11770

[avalanche] Request more peers for their avalanche nodes
ClosedPublic
Actions

Authored by Fabien on Jul 19 2022, 16:08.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCcb78d2179d2d: [avalanche] Request more peers for their avalanche nodes

Summary

Actually the periodic avalanche address request is targeting one peer at a time. This diff makes the node requesting all peers while our quorum is not established or if we should request more because of no suitable node found for polling or dangling proof.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_getavaaddr_more_peers

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19665
Build 39049: Build Diff	build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-clang · build-diff · build-debug
Build 39048: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 19 2022, 16:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 19 2022, 16:08

Fabien requested review of this revision.Jul 19 2022, 16:08

sdulfari requested changes to this revision.Jul 19 2022, 16:26

sdulfari added a subscriber: sdulfari.

sdulfari added inline comments.

test/functional/abc_p2p_getavaaddr.py
259	The actual number may change. No reason to tie the function name to the number.

This revision now requires changes to proceed.Jul 19 2022, 16:26

Harbormaster completed remote builds in B19665: Diff 34419.Jul 19 2022, 16:26

Make the number of targets a parameter

Harbormaster completed remote builds in B19667: Diff 34423.Jul 19 2022, 17:16

Let's evaluate if we can/should request them all

Rebase, request all the peers

Fabien edited the summary of this revision. (Show Details)Jul 22 2022, 11:39

Harbormaster completed remote builds in B19702: Diff 34481.Jul 22 2022, 11:54

sdulfari requested changes to this revision.Jul 23 2022, 06:01

sdulfari added inline comments.

src/net_processing.cpp
1719 ↗	(On Diff #34481)
test/functional/abc_p2p_getavaaddr.py
255–256 ↗	(On Diff #34481)

This revision now requires changes to proceed.Jul 23 2022, 06:01

Update comments

Harbormaster completed remote builds in B19735: Diff 34528.Jul 27 2022, 12:15

Fabien planned changes to this revision.Jul 27 2022, 17:55

Fabien edited the summary of this revision. (Show Details)Jul 28 2022, 15:05

Behavior improvement

Harbormaster completed remote builds in B19745: Diff 34544.Jul 28 2022, 15:23

sdulfari requested changes to this revision.Jul 28 2022, 17:07

sdulfari added inline comments.

src/net_processing.cpp
1685–1698 ↗	(On Diff #34544)	This simplifies the g_avalanche checks.

This revision now requires changes to proceed.Jul 28 2022, 17:07

Feedback

Harbormaster completed remote builds in B19749: Diff 34551.Jul 28 2022, 21:04

sdulfari accepted this revision.Jul 29 2022, 18:42

This revision is now accepted and ready to land.Jul 29 2022, 18:42

Closed by commit rABCcb78d2179d2d: [avalanche] Request more peers for their avalanche nodes (authored by Fabien). · Explain WhyJul 29 2022, 19:11

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCcb78d2179d2d: [avalanche] Request more peers for their avalanche nodes.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

34 lines

test/

functional/

abc_p2p_getavaaddr.py

10 lines

Diff 34419

src/net_processing.cpp

Loading...

test/functional/abc_p2p_getavaaddr.py

Loading...