Page MenuHomePhabricator
Differential D1282

[Part 3] Refactor logging code into a global object
ClosedPublic
Actions

Authored by jimpo on Apr 12 2018, 19:42.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING06db7fa67c81: [Part 3] Refactor logging code into a global object
rABC06db7fa67c81: [Part 3] Refactor logging code into a global object
Summary

util: Move debug file management functions into Logger.

Test Plan

Run bitcoind with different permutations of:
-logtimestamps, -debug, -printtoconsole, -datadir, -shrinkdebugfile

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/init.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2335
Build 2807: Bitcoin ABC Buildbot (legacy)
Build 2806: arc lint + arc unit

Event Timeline

jimpo created this revision.Apr 12 2018, 19:42
Owners added a reviewer: Restricted Owners Package.Apr 12 2018, 19:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2018, 19:42
jimpo added a parent revision: D1281: [Part 2] Refactor logging code into a global object.Apr 12 2018, 19:43
jimpo added a child revision: D1283: [Part 4] Refactor logging code into a global object.Apr 12 2018, 19:48
teamcity added a subscriber: teamcity.Apr 12 2018, 19:48

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2299: Diff 3484.Apr 12 2018, 20:06
teamcity added a comment.Apr 12 2018, 20:06

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

jimpo updated this revision to Diff 3509.Apr 14 2018, 19:30

Rebased.

teamcity added a comment.Apr 14 2018, 19:46

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 14 2018, 20:04

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2318: Diff 3509.Apr 14 2018, 20:04
jimpo updated this revision to Diff 3521.Apr 17 2018, 00:22

Rebased.

teamcity added a comment.Apr 17 2018, 00:39

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 17 2018, 00:57

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2328: Diff 3521!Apr 17 2018, 00:57
jimpo updated this revision to Diff 3530.Apr 17 2018, 07:50

Rebased.

teamcity added a comment.Apr 17 2018, 07:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 17 2018, 08:09

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 17 2018, 08:26

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2335: Diff 3530.Apr 17 2018, 08:26
jimpo updated this revision to Diff 3563.Apr 20 2018, 23:06

Rebased onto master.

teamcity added a comment.Apr 20 2018, 23:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 20 2018, 23:31

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2361: Diff 3563.Apr 20 2018, 23:50
teamcity added a comment.Apr 20 2018, 23:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix added inline comments.Apr 23 2018, 11:07
src/logging.h
56 ↗(On Diff #3563)

Please use std::mutex

deadalnix accepted this revision.Apr 26 2018, 01:45

It overall looks good. Please look into using std::mutex instead of boost::mutex.

src/logging.h
15 ↗(On Diff #3563)

While there are a lot of uses of boost::mutex in the codebase remaining - we move to C++11 and we should use std::mutex instead whenever possible.

This revision is now accepted and ready to land.Apr 26 2018, 01:45
Closed by commit rABC06db7fa67c81: [Part 3] Refactor logging code into a global object (authored by jimpo). · Explain WhyApr 27 2018, 01:47
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
16 lines
62 lines

Diff 3530

View Options

src/init.cpp

Loading...
View Options

src/logging.h

Loading...
View Options

src/logging.cpp

Loading...