Page MenuHomePhabricator

[Part 3] Refactor logging code into a global object
ClosedPublic

Authored by jimpo on Apr 12 2018, 19:42.

Details

Summary

util: Move debug file management functions into Logger.

Test Plan

Run bitcoind with different permutations of:
-logtimestamps, -debug, -printtoconsole, -datadir, -shrinkdebugfile

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/init.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2335
Build 2807: Bitcoin ABC Buildbot (legacy)
Build 2806: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 12 2018, 19:42
src/logging.h
56 ↗(On Diff #3563)

Please use std::mutex

It overall looks good. Please look into using std::mutex instead of boost::mutex.

src/logging.h
15 ↗(On Diff #3563)

While there are a lot of uses of boost::mutex in the codebase remaining - we move to C++11 and we should use std::mutex instead whenever possible.

This revision is now accepted and ready to land.Apr 26 2018, 01:45
This revision was automatically updated to reflect the committed changes.