Page MenuHomePhabricator
Differential D12819

Fix implicit-integer-sign-change in bloom
ClosedPublic
Actions

Authored by PiRK on Dec 8 2022, 12:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6b26906907bf: Fix implicit-integer-sign-change in bloom
Summary

This is a backport of core#24219
Depends on D12818

Test Plan

With UBSAN
ninja && ninja check check-functional

Diff Detail

Event Timeline

PiRK created this revision.Dec 8 2022, 12:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 8 2022, 12:35
PiRK requested review of this revision.Dec 8 2022, 12:35
teamcity edited the summary of this revision. (Show Details)Dec 8 2022, 12:35
PiRK added a child revision: D12820: test: Avoid testing negative block heights.Dec 8 2022, 12:36
Harbormaster completed remote builds in B21474: Diff 37123.Dec 8 2022, 13:22
Fabien requested changes to this revision.Dec 8 2022, 14:52
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/bloom.cpp
282

You missed that one

This revision now requires changes to proceed.Dec 8 2022, 14:52
PiRK updated this revision to Diff 37131.Dec 8 2022, 15:16

add the U to the correct line (the bitwise OR cannot make a positive number negative))

Harbormaster completed remote builds in B21478: Diff 37131.Dec 8 2022, 15:40
Fabien accepted this revision.Dec 8 2022, 16:01
This revision is now accepted and ready to land.Dec 8 2022, 16:01
Closed by commit rABC6b26906907bf: Fix implicit-integer-sign-change in bloom (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyDec 9 2022, 07:25
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC6b26906907bf: Fix implicit-integer-sign-change in bloom.

Revision Contents
Changeset List

PathSize
src/
8 lines
test/
sanitizer_suppressions/
1 line

Diff 37123

View Options

src/bloom.cpp

Loading...
View Options

test/sanitizer_suppressions/ubsan

Loading...