Differential D13123

mempool: Removed the ancestor_score index
ClosedPublic
Actions

Authored by Fabien on Feb 10 2023, 14:24.

Tags

None

Subscribers

None

Details

Reviewers

PiRK
sdulfari

Group Reviewers

Restricted Project

Commits

rABC856203e358f4: mempool: Removed the ancestor_score index

Summary

This is no longer being used (it was used previously for mining). After
the CPFP-removal from the mining code in a previous commit, this index
is no longer needed.

Also removed the comparator CompareTxMemPoolEntryByAncestorFee and the tests for this index and comparator.

Port of bchn#1113.

Depends on D13122.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

MR1113

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21995
Build 43625: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 43624: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 10 2023, 14:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2023, 14:24

Fabien requested review of this revision.Feb 10 2023, 14:24

teamcity edited the summary of this revision. (Show Details)Feb 10 2023, 14:24

Harbormaster completed remote builds in B21977: Diff 37876.Feb 10 2023, 14:38

PiRK accepted this revision.Feb 14 2023, 09:42

This revision is now accepted and ready to land.Feb 14 2023, 09:42

sdulfari accepted this revision.Feb 14 2023, 21:53

Rebase

Fabien added a child revision: D13133: mempool: Add topological index, enforce consistency, updated reorg logic.Feb 15 2023, 16:49

Harbormaster completed remote builds in B21995: Diff 37904.Feb 15 2023, 17:28

Closed by commit rABC856203e358f4: mempool: Removed the ancestor_score index (authored by CCulianu, committed by Fabien). · Explain WhyFeb 15 2023, 18:41

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC856203e358f4: mempool: Removed the ancestor_score index.

Revision Contents
Changeset List

Path

Size

src/

test/

mempool_tests.cpp

142 lines

51 lines

5 lines

Diff 37904

src/test/mempool_tests.cpp

Loading...

src/txmempool.h

Loading...

src/txmempool.cpp

Loading...