Page MenuHomePhabricator
Differential D1446

Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM
ClosedPublic
Actions

Authored by sickpig on May 24 2018, 09:47.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGaa4cd96c94a2: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM
rABCaa4cd96c94a2: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM
Summary

as per title

Test Plan

make check && test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
discorouge_witness (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2636
Build 3386: Bitcoin ABC Buildbot (legacy)
Build 3385: arc lint + arc unit

Event Timeline

sickpig created this revision.May 24 2018, 09:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2018, 09:47
teamcity added a subscriber: teamcity.May 24 2018, 09:48

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

sickpig added a comment.May 24 2018, 09:49

Dunno why but for some reason I seem to have added src/test/buildenv.py by error, wonder if we could add it to .gitignore

going to remove it later on got to go now.

teamcity added a comment.May 24 2018, 10:24

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2624: Diff 3952.May 24 2018, 10:24
sickpig updated this revision to Diff 3955.May 24 2018, 11:56

Remove src/test/buildenv.py

teamcity added a comment.May 24 2018, 11:57

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

sickpig updated this revision to Diff 3957.May 24 2018, 11:59

Squash local commits

teamcity added a comment.May 24 2018, 12:00

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2627: Diff 3955.May 24 2018, 12:33
teamcity added a comment.May 24 2018, 12:33

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

teamcity added a comment.May 24 2018, 12:37

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2629: Diff 3957.May 24 2018, 12:38
deadalnix requested changes to this revision.May 24 2018, 13:33
deadalnix added inline comments.
src/script/interpreter.h
91 ↗(On Diff #3957)

Reformat comment.

This revision now requires changes to proceed.May 24 2018, 13:33
sickpig updated this revision to Diff 3964.May 24 2018, 13:45

Format comment

teamcity added a comment.May 24 2018, 13:46

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.May 24 2018, 13:55
This revision is now accepted and ready to land.May 24 2018, 13:55
sickpig updated this revision to Diff 3966.May 24 2018, 13:56

internal branch reorg. no code changes

teamcity added a comment.May 24 2018, 13:57

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2634: Diff 3964.May 24 2018, 14:20
teamcity added a comment.May 24 2018, 14:20

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Closed by commit rABCaa4cd96c94a2: Get rid of SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM (authored by sickpig). · Explain WhyMay 24 2018, 14:24
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.May 24 2018, 14:34

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2636: Diff 3966.May 24 2018, 14:34

Revision Contents
Changeset List

PathSize
src/
policy/
3 lines
script/
7 lines
1 line
2 lines
test/
data/
16 lines
2 lines
2 lines

Diff 3966

View Options

src/policy/policy.h

Loading...
View Options

src/script/interpreter.h

Loading...
View Options

src/script/script_error.h

Loading...
View Options

src/script/script_error.cpp

Loading...
View Options

src/test/data/tx_valid.json

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/scriptflags.cpp

Loading...