Differential D14021

Move OutputGroup positive only filtering into Insert
ClosedPublic
Actions

Authored by Fabien on Jun 8 2023, 21:03.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC1afb4e8964c7: Move OutputGroup positive only filtering into Insert

Summary

This is a partial backport of core#20040:
https://github.com/bitcoin/bitcoin/pull/20040/commits/416d74fb1687ae1d47a58c153d09d9afe0b6dc60

Depends on D14020.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR20040_p5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23963
Build 47536: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-debug · build-clang · build-diff · build-bench
Build 47535: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 8 2023, 21:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2023, 21:03

Fabien requested review of this revision.Jun 8 2023, 21:03

teamcity edited the summary of this revision. (Show Details)Jun 8 2023, 21:03

Fabien added a child revision: D14022: Explicitly filter out partial groups when we don't want them.Jun 8 2023, 21:03

Harbormaster completed remote builds in B23957: Diff 40671.Jun 8 2023, 21:43

Rebase

Harbormaster completed remote builds in B23963: Diff 40681.Jun 9 2023, 06:16

PiRK accepted this revision.Jun 9 2023, 06:22

This revision is now accepted and ready to land.Jun 9 2023, 06:22

Closed by commit rABC1afb4e8964c7: Move OutputGroup positive only filtering into Insert (authored by Andrew Chow <achow101-github@achow101.com>, committed by Fabien). · Explain WhyJun 9 2023, 13:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1afb4e8964c7: Move OutputGroup positive only filtering into Insert.

Revision Contents
Changeset List

Path

Size

src/

bench/

coin_selection.cpp

2 lines

wallet/

5 lines

53 lines

13 lines

49 lines

test/

coinselector_tests.cpp

4 lines

Diff 40681

View Options

src/bench/coin_selection.cpp

View Options

src/wallet/coinselection.h

View Options

src/wallet/coinselection.cpp

View Options

src/wallet/spend.h

View Options

src/wallet/spend.cpp

View Options

src/wallet/test/coinselector_tests.cpp

Move OutputGroup positive only filtering into InsertClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40681

src/bench/coin_selection.cpp

src/wallet/coinselection.h

src/wallet/coinselection.cpp

src/wallet/spend.h

src/wallet/spend.cpp

src/wallet/test/coinselector_tests.cpp

Move OutputGroup positive only filtering into Insert
ClosedPublic
Actions

Revision Contents
Changeset List