Page MenuHomePhabricator
Differential D1526

Add support for both way comparison for uint256/uint160
ClosedPublic
Actions

Authored by deadalnix on Jul 1 2018, 00:46.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGc4327aee8751: Add support for both way comparison for uint256/uint160
rABCc4327aee8751: Add support for both way comparison for uint256/uint160
Summary

Right now, they only compare one way, which is inconvenient.

Test Plan

Added test cases to cover the new function.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
uint256comp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2779
Build 3668: Bitcoin ABC Buildbot (legacy)
Build 3667: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 1 2018, 00:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2018, 00:46
teamcity added a subscriber: teamcity.Jul 1 2018, 00:48

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 1 2018, 01:21

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2778: Diff 4172.Jul 1 2018, 01:21
deadalnix updated this revision to Diff 4173.Jul 1 2018, 13:12

Add variosu nits and a comment about endianess

teamcity added a comment.Jul 1 2018, 13:12

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 1 2018, 13:50

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2779: Diff 4173.Jul 1 2018, 13:50
deadalnix added a child revision: D1527: Modify uint256's comparison to use proper endianess.Jul 1 2018, 19:13
schancel accepted this revision.Jul 2 2018, 15:23
This revision is now accepted and ready to land.Jul 2 2018, 15:23
Closed by commit rABCc4327aee8751: Add support for both way comparison for uint256/uint160 (authored by deadalnix). · Explain WhyJul 2 2018, 23:10
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
test/
39 lines
22 lines
18 lines

Diff 4173

View Options

src/test/uint256_tests.cpp

Loading...
View Options

src/uint256.h

Loading...
View Options

src/uint256.cpp

Loading...