Paths

Table of Contentst

Differential D14066

Increase the minerfund IFP reward
ClosedPublic
Actions

Authored by Fabien on Jun 15 2023, 15:27.

Tags

None

Subscribers

Details

Reviewers

Mengerian
PiRK

Group Reviewers

Restricted Project

Commits

rABC10577b475f3a: Increase the minerfund IFP reward

Summary

Bump the IFP reward starting on November 15, 2023.
This is done to maintain enough earnings for keeping the eCash project
moving forward despite the price getting lower during the bear market.

Test Plan

ninja check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bump_ifp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25303
Build 50191: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 50190: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 15 2023, 15:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2023, 15:27

Fabien requested review of this revision.Jun 15 2023, 15:27

Fabien changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Jun 15 2023, 15:27

Fabien changed the edit policy from "All Users" to "Restricted Project (Project)".

Fabien edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B24056: Diff 40810.Jun 15 2023, 15:43

The code looks good.

test/functional/abc_feature_minerfund.py
50 ↗	(On Diff #40810)	The `ratio` parameter is not necessary in these subfunctions, as it is always equal to the `ratio` var from the outer scope.

Fabien edited the summary of this revision. (Show Details)Jun 19 2023, 12:14

Fabien removed a parent revision: D14062: Add Cowperthwaite activation logic.

Rebase, simplify the test as per review.
Note that this still lacking a release note.

Harbormaster completed remote builds in B24086: Diff 40857.Jun 19 2023, 12:43

FYI this will crash the price. Something to be aware of.

majcosta added a subscriber: majcosta.Aug 24 2023, 12:22

Rebase

Harbormaster completed remote builds in B25302: Diff 42597.Oct 9 2023, 16:42

Rebase

Harbormaster completed remote builds in B25303: Diff 42600.Oct 9 2023, 17:23

Mengerian accepted this revision.Oct 9 2023, 17:40

This revision is now accepted and ready to land.Oct 9 2023, 17:40

PiRK accepted this revision.Oct 9 2023, 18:19

PiRK added inline comments.

src/test/minerfund_tests.cpp
84		The comment needs to be updated.
84 ↗	(On Diff #42597)	the comment needs updating

Closed by commit rABC10577b475f3a: Increase the minerfund IFP reward (authored by Fabien). · Explain WhyOct 9 2023, 20:25

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC10577b475f3a: Increase the minerfund IFP reward.

Fabien changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Oct 9 2023, 20:25

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

8 lines

src/

6 lines

16 lines

node/

3 lines

policy/

block/

4 lines

rpc/

4 lines

test/

minerfund_tests.cpp

35 lines

policy_block_tests.cpp

55 lines

test/

functional/

abc_feature_minerfund.py

27 lines

abc_mining_basic.py

32 lines

abc_p2p_avalanche_policy_minerfund.py

26 lines

Diff 42600

doc/release-notes.md

Loading...

src/minerfund.h

Loading...

src/minerfund.cpp

Loading...

src/node/miner.cpp

Loading...

src/policy/block/minerfund.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/test/minerfund_tests.cpp

Loading...

src/test/policy_block_tests.cpp

Loading...

test/functional/abc_feature_minerfund.py

Loading...

test/functional/abc_mining_basic.py

Loading...

test/functional/abc_p2p_avalanche_policy_minerfund.py

Loading...