Page MenuHomePhabricator
Differential D14749

[net] Return CService from GetLocalAddrForPeer and GetLocalAddress
ClosedPublic
Actions

Authored by PiRK on Nov 7 2023, 12:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC105ec9bd23db: [net] Return CService from GetLocalAddrForPeer and GetLocalAddress
Summary

This is a partial backport of core#25514
https://github.com/bitcoin/bitcoin/pull/25514/commits/5961f8eea1ad5be1a4bf8da63651e197a20359b2

Depends on D14748

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 7 2023, 12:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 7 2023, 12:33
PiRK requested review of this revision.Nov 7 2023, 12:33
teamcity edited the summary of this revision. (Show Details)Nov 7 2023, 12:34
PiRK added a child revision: D14750: [net processing] Remove CNode::nLocalServices.Nov 7 2023, 12:44
Harbormaster completed remote builds in B25554: Diff 42978.Nov 7 2023, 13:01
Fabien accepted this revision.Nov 8 2023, 09:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net.cpp
216 ↗(On Diff #42978)
This revision is now accepted and ready to land.Nov 8 2023, 09:49
PiRK updated this revision to Diff 42992.Nov 8 2023, 10:21

rebase and comment nit

Harbormaster completed remote builds in B25566: Diff 42992.Nov 8 2023, 11:01
Closed by commit rABC105ec9bd23db: [net] Return CService from GetLocalAddrForPeer and GetLocalAddress (authored by dergoegge <n.goeggi@gmail.com>, committed by PiRK). · Explain WhyNov 8 2023, 15:10
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC105ec9bd23db: [net] Return CService from GetLocalAddrForPeer and GetLocalAddress.

Revision Contents
Changeset List

PathSize
src/
7 lines
31 lines
10 lines
test/
8 lines

Diff 43004

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...