Page MenuHomePhabricator
Differential D1563

Add CHECKDATASIG opcode.
ClosedPublic
Actions

Authored by deadalnix on Jul 14 2018, 12:33.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGd93b4f79b89b: Add CHECKDATASIG opcode.
rABCd93b4f79b89b: Add CHECKDATASIG opcode.
Summary

The opcode is constantly disabled.

Test Plan

Add test cases to ensure the opcode is disabled.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
opcheckdatasig
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2885
Build 3874: Bitcoin ABC Buildbot (legacy)
Build 3873: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 14 2018, 12:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2018, 12:33
teamcity added a subscriber: teamcity.Jul 14 2018, 12:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 14 2018, 13:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2868: Diff 4301.Jul 14 2018, 13:12
deadalnix planned changes to this revision.Jul 14 2018, 13:30
deadalnix added a comment.Jul 14 2018, 13:39

Holy shit, script doesn't check for bad opcodes in dead path.

deadalnix updated this revision to Diff 4302.Jul 14 2018, 16:51

Do not disable the opcode as it also disable it on dead path.

teamcity added a comment.Jul 14 2018, 16:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 14 2018, 17:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2869: Diff 4302!Jul 14 2018, 17:31
schancel accepted this revision.Jul 16 2018, 16:41
schancel added a subscriber: schancel.
schancel added inline comments.
src/test/monolith_opcodes.cpp
17 ↗(On Diff #4302)

Why did this move?

This revision is now accepted and ready to land.Jul 16 2018, 16:41
deadalnix added inline comments.Jul 16 2018, 18:05
src/test/monolith_opcodes.cpp
17 ↗(On Diff #4302)

flagsets needs to be in the test's namespace or we get a definition clash with checkdatasig_tests.cpp

teamcity added a comment.Jul 16 2018, 18:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 4325.Jul 16 2018, 18:14

rebase

teamcity added a comment.Jul 16 2018, 18:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1564: Add a flag to activate OP_CHECKDATASIG.Jul 16 2018, 18:28
teamcity added a comment.Jul 16 2018, 18:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Jul 16 2018, 18:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2885: Diff 4325!Jul 16 2018, 18:52
Closed by commit rABCd93b4f79b89b: Add CHECKDATASIG opcode. (authored by deadalnix). · Explain WhyJul 16 2018, 19:48
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
script/
4 lines
4 lines
4 lines
test/
1 line
45 lines
data/
14 lines
4 lines
test/
functional/
test_framework/
8 lines

Diff 4325

View Options

src/Makefile.test.include

Loading...
View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script.h

Loading...
View Options

src/script/script.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/checkdatasig_tests.cpp

Loading...
View Options

src/test/data/script_tests.json

Loading...
View Options

src/test/monolith_opcodes.cpp

Loading...
View Options

test/functional/test_framework/script.py

Loading...