Page MenuHomePhabricator
Differential D1597

Pass flags down to GetP2SHSigOpCount and GetSigOpCountWithoutP2SH
ClosedPublic
Actions

Authored by deadalnix on Jul 25 2018, 17:57.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING41d998153924: Pass flags down to GetP2SHSigOpCount and GetSigOpCountWithoutP2SH
rABC41d998153924: Pass flags down to GetP2SHSigOpCount and GetSigOpCountWithoutP2SH
Summary

This will ensure we can use flags to tweak the way sigops are counted in the future. That is necessary for the activation of OP_CHECKDATASIG .

Depends on D1596

Test Plan

Added test cases for the logic change.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sigopcountflag
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2958
Build 4016: Bitcoin ABC Buildbot (legacy)
Build 4015: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 25 2018, 17:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2018, 17:57
teamcity added a subscriber: teamcity.Jul 25 2018, 17:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 25 2018, 18:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2947: Diff 4410!Jul 25 2018, 18:38
jasonbcox accepted this revision.Jul 25 2018, 19:21
This revision is now accepted and ready to land.Jul 25 2018, 19:21
deadalnix updated this revision to Diff 4424.Jul 25 2018, 21:06

rebase

teamcity added a comment.Jul 25 2018, 21:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2958: Diff 4424.Jul 25 2018, 21:49
teamcity added a comment.Jul 25 2018, 21:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC41d998153924: Pass flags down to GetP2SHSigOpCount and GetSigOpCountWithoutP2SH (authored by deadalnix). · Explain WhyJul 25 2018, 23:04
This revision was automatically updated to reflect the committed changes.
markblundeberg added a subscriber: markblundeberg.Jan 27 2020, 06:23
markblundeberg added inline comments.
src/validation.cpp
455 ↗(On Diff #4429)

(note: this introduced an immediate soft fork, satoshi style ;-D )

Revision Contents
Changeset List

PathSize
src/
4 lines
policy/
8 lines
test/
23 lines
15 lines
30 lines

Diff 4424

View Options

src/miner.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/test/script_P2SH_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...