Page MenuHomePhabricator
Differential D1659

Seperated BlockStatus class from chain.h file and updated .h and .cpp dependencies.
ClosedPublic
Actions

Authored by nakihito on Aug 19 2018, 23:54.

Details

Reviewers
jasonbcox
schancel
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING62591dfadea3: Seperated BlockStatus class from chain.h file and updated .h and .cpp…
rABC62591dfadea3: Seperated BlockStatus class from chain.h file and updated .h and .cpp…
Summary

Continues work on T380, dependent on D1656. Removed the CBlockStatus class from chain.h and placed it into its own .h file, blockstatus.h. Updated other .h and .cpp files for dependencies.

Test Plan

Make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
SeperatingBlockStatusClass
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/validation.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 3092
Build 4271: Bitcoin ABC Buildbot (legacy)
Build 4270: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 19 2018, 23:54
Owners added a reviewer: Restricted Owners Package.Aug 19 2018, 23:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 19 2018, 23:54
teamcity added a subscriber: teamcity.Aug 19 2018, 23:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3091: Diff 4600!Aug 20 2018, 00:30
teamcity added a comment.Aug 20 2018, 00:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

nakihito updated this revision to Diff 4601.Aug 20 2018, 00:54

Fixed white spacing issue in validation.cpp.

teamcity added a comment.Aug 20 2018, 00:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 20 2018, 01:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3092: Diff 4601.Aug 20 2018, 01:31
nakihito mentioned this in D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..Aug 20 2018, 02:58
jasonbcox accepted this revision.Aug 20 2018, 21:47
This revision is now accepted and ready to land.Aug 20 2018, 21:47
Closed by commit rABC62591dfadea3: Seperated BlockStatus class from chain.h file and updated .h and .cpp… (authored by nakihito). · Explain WhySep 4 2018, 05:48
This revision was automatically updated to reflect the committed changes.
nakihito mentioned this in D1719: Resolved forgotten chain.h merge..Sep 4 2018, 22:29
nakihito mentioned this in rABC5977efad639b: Resolved forgotten chain.h merge..Sep 7 2018, 20:09
nakihito mentioned this in rSTAGING5977efad639b: Resolved forgotten chain.h merge..Sep 27 2018, 19:01

Revision Contents
Changeset List

PathSize
src/
1 line
117 lines
105 lines
test/
2 lines
4 lines

Diff 4601

View Options

src/Makefile.am

Loading...
View Options

src/blockstatus.h

Loading...
View Options

src/chain.h

Loading...
View Options

src/test/blockstatus_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...