Page MenuHomePhabricator

Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies.

Authored by nakihito on Aug 14 2018, 20:50.



Continues T380, dependent on D1655. Created new blockvalidity.h file removing enum class BlockValidity from chain.h. Also updated other .h and .cpp files using BlockValidity.

Test Plan

make check

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 14 2018, 20:50

blockvalidity.h is missing an #include "tinyformat.h" under line 8 for strprintf() which is present in D1655 (which this depends on). Will update after D1654 and D1655 are passed.

jasonbcox requested changes to this revision.Aug 15 2018, 22:28
jasonbcox added inline comments.
7 ↗(On Diff #4591)

Add to

Inlcuded blockvalidity.h in src/, fixed white space issue.

Added endif include guard comment for blockvalidity.h.

This revision is now accepted and ready to land.Aug 20 2018, 21:44
This revision was automatically updated to reflect the committed changes.