Differential D1656

Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies.
ClosedPublic
Actions

Authored by nakihito on Aug 14 2018, 20:50.

Tags

None

Subscribers

Details

Reviewers

jasonbcox
deadalnix
schancel

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGb59151daf3ef: Seperated enum class BlockValidity from chain.h into its own .h file and…
rABCb59151daf3ef: Seperated enum class BlockValidity from chain.h into its own .h file and…

Summary

Continues T380, dependent on D1655. Created new blockvalidity.h file removing enum class BlockValidity from chain.h. Also updated other .h and .cpp files using BlockValidity.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

SeperatingBlockValidityClass

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/validation.cpp:1	CFMT	Code style violation

Unit

No Test Coverage

Build Status

Buildable 3093
Build 4273: Bitcoin ABC Buildbot (legacy)
Build 4272: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 14 2018, 20:50

Owners added a reviewer: Restricted Owners Package.Aug 14 2018, 20:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2018, 20:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3084: Diff 4591!Aug 14 2018, 20:52

blockvalidity.h is missing an #include "tinyformat.h" under line 8 for strprintf() which is present in D1655 (which this depends on). Will update after D1654 and D1655 are passed.

jasonbcox requested changes to this revision.Aug 15 2018, 22:28

jasonbcox added inline comments.

src/blockvalidity.h
7 ↗	(On Diff #4591)	Add to Makefile.am

Inlcuded blockvalidity.h in src/Makefile.am, fixed white space issue.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3090: Diff 4599.Aug 19 2018, 23:27

nakihito mentioned this in D1659: Seperated BlockStatus class from chain.h file and updated .h and .cpp dependencies..Aug 19 2018, 23:54

Added endif include guard comment for blockvalidity.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3093: Diff 4602.Aug 20 2018, 03:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Aug 20 2018, 21:44

This revision is now accepted and ready to land.Aug 20 2018, 21:44

Closed by commit rABCb59151daf3ef: Seperated enum class BlockValidity from chain.h into its own .h file and… (authored by nakihito). · Explain WhySep 4 2018, 05:43

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in rABC62591dfadea3: Seperated BlockStatus class from chain.h file and updated .h and .cpp….Sep 4 2018, 05:48

nakihito mentioned this in D1719: Resolved forgotten chain.h merge..Sep 4 2018, 22:29

nakihito mentioned this in rABC5977efad639b: Resolved forgotten chain.h merge..Sep 7 2018, 20:09

nakihito mentioned this in rSTAGING62591dfadea3: Seperated BlockStatus class from chain.h file and updated .h and .cpp….Sep 27 2018, 19:00

nakihito mentioned this in rSTAGING5977efad639b: Resolved forgotten chain.h merge..

Revision Contents
Changeset List

Path

Size

src/

1 line

blockvalidity.h

50 lines

41 lines

net_processing.cpp

1 line

rpc/

1 line

test/

blockindex_tests.cpp

1 line

blockstatus_tests.cpp

1 line

1 line

Diff 4602

src/Makefile.am

Loading...

src/blockvalidity.h

Loading...

src/chain.h

Loading...

src/net_processing.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/test/blockindex_tests.cpp

Loading...

src/test/blockstatus_tests.cpp

Loading...

src/validation.cpp

Loading...