Page MenuHomePhabricator

Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .cpp dependencies.
ClosedPublic

Authored by nakihito on Aug 14 2018, 20:27.

Details

Summary

Contiues work on T380, dependent on D1654. The class CDiskBlockPos originally located in Chain.h has been seperated from Chain.h and placed into its own .h file (diskblockpos.h).

Test Plan

Executes make check and passes all tests.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Aug 14 2018, 20:27
Owners added a reviewer: Restricted Owners Package.Aug 14 2018, 20:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2018, 20:27
jasonbcox accepted this revision as: jasonbcox.Aug 14 2018, 21:18
deadalnix requested changes to this revision.Aug 15 2018, 19:00

This will break gitian build unless the new header is specified in Makefile.am .

This revision now requires changes to proceed.Aug 15 2018, 19:00
nakihito updated this revision to Diff 4598.Aug 19 2018, 22:29

Added diskblockpos.h to src/Makefile.am.

deadalnix requested changes to this revision.Aug 21 2018, 13:11
deadalnix added inline comments.
src/validation.h
19 ↗(On Diff #4598)

CDiskBlockPos is only used by pointer or ref, please use a forward declaration instead of an include.

This revision now requires changes to proceed.Aug 21 2018, 13:11
nakihito updated this revision to Diff 4711.Aug 28 2018, 01:52

Removed unnecessary include statement in src/validation.h for CDiskBlockPos and replaced it with forward declaration.

nakihito added inline comments.Aug 28 2018, 03:00
src/validation.h
19 ↗(On Diff #4598)

Ah, you are correct. Consider it fixed.

deadalnix accepted this revision.Sep 3 2018, 11:52
This revision is now accepted and ready to land.Sep 3 2018, 11:52
This revision was automatically updated to reflect the committed changes.