Page MenuHomePhabricator

Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .cpp dependencies.

Authored by nakihito on Aug 14 2018, 20:27.



Contiues work on T380, dependent on D1654. The class CDiskBlockPos originally located in Chain.h has been seperated from Chain.h and placed into its own .h file (diskblockpos.h).

Test Plan

Executes make check and passes all tests.

Diff Detail

rABC Bitcoin ABC
Lint OK
No Unit Test Coverage
Build Status
Buildable 3166
Build 4419: Bitcoin ABC Buildbot (legacy)
Build 4418: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 14 2018, 20:27
deadalnix requested changes to this revision.Aug 15 2018, 19:00

This will break gitian build unless the new header is specified in .

This revision now requires changes to proceed.Aug 15 2018, 19:00

Added diskblockpos.h to src/

deadalnix requested changes to this revision.Aug 21 2018, 13:11
deadalnix added inline comments.
19 ↗(On Diff #4598)

CDiskBlockPos is only used by pointer or ref, please use a forward declaration instead of an include.

This revision now requires changes to proceed.Aug 21 2018, 13:11

Removed unnecessary include statement in src/validation.h for CDiskBlockPos and replaced it with forward declaration.

19 ↗(On Diff #4598)

Ah, you are correct. Consider it fixed.

This revision is now accepted and ready to land.Sep 3 2018, 11:52
This revision was automatically updated to reflect the committed changes.