[avalanche] pass the processor to Chainstate::ActivateBestChain[Step]
ClosedPublic
Actions

Authored by PiRK on Jun 4 2024, 10:11.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf3bc78e54ff0: [avalanche] pass the processor to Chainstate::ActivateBestChain[Step]

Summary

Another step in removing access to the g_avalanche global in Chainstate code.

This adds g_avalanche access in rpc/blockchain.cpp, but this is only temporary because in a later diff the processor will be avaialble through the node context.

Depends on D16265

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29207
Build 57950: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-debug · build-diff · build-clang
Build 57949: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 4 2024, 10:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2024, 10:11

PiRK requested review of this revision.Jun 4 2024, 10:11

PiRK added a child revision: D16267: [avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile and ThreadImport.

Harbormaster completed remote builds in B29199: Diff 48079.Jun 4 2024, 10:40

Fabien requested changes to this revision.Jun 4 2024, 11:44

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/test/processor_tests.cpp
2222 ↗	(On Diff #48079)	You can actually avoid this and use m_processor directly now
src/rpc/blockchain.cpp
1604 ↗	(On Diff #48079)	This will prevent using invalidateblock if avalanche is not enabled (even if that doesn't hold right now that's the expectation behind `EnsureAvalanche()`), which is not what you want. Same for the other RPCs below