Resolves T407. Removes CAddress from protocol.h and protocol.cpp into its own files: address.h and address.cpp.
Details
Details
- Reviewers
jasonbcox deadalnix schancel - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Maniphest Tasks
- T407: protocol.h/cpp: Move CAddress to its own header/source files
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- MoveCAddress
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3338 Build 4759: Bitcoin ABC Buildbot (legacy) Build 4758: arc lint + arc unit
Event Timeline
| src/address.cpp | ||
|---|---|---|
| 9 | Instead of a TODO, I think you should do this diff first. | |
| src/rpc/net.cpp | ||
| 25 | The fact that this compiles is a fluke. You should always include from source files, and forward declarations may be used in headers where pointers or references only are used. | |
| src/test/test_bitcoin_fuzzy.cpp | ||
| 29 | This needs to be an include | |
| src/address.cpp | ||
|---|---|---|
| 9 | Part of every ticket is identifying requirements. If you notice that doing other tasks before the ticket in question is necessary, then by all means do it. :) btw, check out the #dev discussion regarding whether or not ServiceFlags should leave protocol.h. There's a case for leaving it in, but (in my opinion) it should only be done if protocol.h can be slimmed down and renamed to netprotocol.h or something that makes it obvious that it is net-code and not consensus-code. | |
Comment Actions
Fixed accidental forward includes in a couple of .cpp files and replaced them with include statements. Also removed TODO comment in address.cpp because there was no consensus reached agreeing to the splitting of CServiceFlags.
Comment Actions
Trying to clear off the review queue temporarily. Will get back to review this later.