Page MenuHomePhabricator

Change default for excessive block size and generated block size
ClosedPublic

Authored by deadalnix on Jun 15 2017, 14:23.

Details

Summary

Now that we ensure that the 1MB limit is respected before the fork is activated, we can safely increase defaults up to the value we want for the UAHF.

The generated block size is increased to 2MB and the maximum block size to 8MB by default.

Test Plan

Updated tests to ensure the behavior is as expected.
Run the extended test suite to make sure they all pass.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
newdefaults
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 315
Build 315: arc lint + arc unit

Event Timeline

Just revert the Python wildcard import please, rest is fine.

qa/rpc-tests/abc-p2p-fullblocktest.py
21 ↗(On Diff #497)

No.

Do not add wildcard imports to tests. This is bad Python practice just like blanket namespace imports are in C++ :-)

If the list gets too long, put them in parentheses and spread them over multiple lines.

qa/rpc-tests/abc-rpc.py
50 ↗(On Diff #497)

Why the specific EB change down from 8MB to 2MB without retaining higher-EB checks?

I would advise even setting to a high size like 16MB or 32MB in addition to the 2MB check.

This revision now requires changes to proceed.Jun 16 2017, 11:45
qa/rpc-tests/abc-rpc.py
50 ↗(On Diff #497)

Because 8MB is now the default, so it is testing nothing.

deadalnix edited edge metadata.

Remove star import

Add a test for block larger than 8MB in abc-rpc.py

Actually remove star import

All review comments addressed, accepting.

This revision is now accepted and ready to land.Jun 16 2017, 11:59
This revision was automatically updated to reflect the committed changes.