Page MenuHomePhabricator
Differential D1983

[Part 1 of 2] [qa] receivedby.py cleanup and fixes
ClosedPublic
Actions

Authored by schancel on Oct 29 2018, 23:25.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING7e5ed0e6b988: [Part 1 of 2] [qa] receivedby.py cleanup and fixes
rABC7e5ed0e6b988: [Part 1 of 2] [qa] receivedby.py cleanup and fixes
Summary

[qa] Tidy up receivedby.py

  • Fix flake8 warnings
  • Remove the useless get_sub_array_from_array() function
  • Reduce runtime for receivedby.py by about half by only using two nodes

Backport of Core PR11055

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11055
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3716
Build 5507: Bitcoin ABC Buildbot (legacy)
Build 5506: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 29 2018, 23:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2018, 23:25
teamcity added a subscriber: teamcity.Oct 29 2018, 23:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel added a child revision: D1984: [Part 2 of 2] [wallet] getreceivedbyaddress should return error if address is not mine.Oct 29 2018, 23:26
teamcity added a comment.Oct 29 2018, 23:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3716: Diff 5576.Oct 29 2018, 23:33
schancel edited the summary of this revision. (Show Details)Oct 30 2018, 00:06
jasonbcox accepted this revision.Oct 30 2018, 00:07
This revision is now accepted and ready to land.Oct 30 2018, 00:07
Closed by commit rABC7e5ed0e6b988: [Part 1 of 2] [qa] receivedby.py cleanup and fixes (authored by John Newbery <john@johnnewbery.com>, committed by schancel). · Explain WhyOct 30 2018, 00:17
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D2635: Remove enable_mocktime from wallet_listreceivedby.Mar 1 2019, 12:22
Fabien mentioned this in rABC1ddf95e15d4c: Remove enable_mocktime from wallet_listreceivedby.Mar 1 2019, 14:15
Fabien mentioned this in rSTAGING1ddf95e15d4c: Remove enable_mocktime from wallet_listreceivedby.Sep 18 2019, 22:36

Revision Contents
Changeset List

PathSize
test/
functional/
90 lines

Diff 5576

View Options

test/functional/receivedby.py

Loading...