Page MenuHomePhabricator
Differential D2013

[rpc] Add a unittest for IsDeprecatedRPCEnabled
ClosedPublic
Actions

Authored by schancel on Nov 6 2018, 18:44.

Details

Reviewers
Fabien
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGb4460fcaa584: [rpc] Add a unittest for IsDeprecatedRPCEnabled
rABCb4460fcaa584: [rpc] Add a unittest for IsDeprecatedRPCEnabled
Summary

As per title. This is in preparation for re-enabling the estimatefee rpc.

Test Plan
make src/test/test_bitcoin && src/test/test_bitcoin --run_test=server_tests/server_IsDeprecatedRPCEnabled

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-deprecation-tests (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3788
Build 5650: Bitcoin ABC Buildbot (legacy)
Build 5649: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 6 2018, 18:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2018, 18:44
schancel added a child revision: D2012: [rpc] Undeprecate estimatefee.Nov 6 2018, 18:44
teamcity added a subscriber: teamcity.Nov 6 2018, 18:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 5674.Nov 6 2018, 18:46

Include missing file

teamcity added a comment.Nov 6 2018, 18:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 6 2018, 18:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3788: Diff 5672!Nov 6 2018, 18:50
teamcity added a comment.Nov 6 2018, 18:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3790: Diff 5674.Nov 6 2018, 18:57
Fabien accepted this revision as: Fabien.Nov 6 2018, 19:51
This revision is now accepted and ready to land.Nov 6 2018, 19:51
jasonbcox accepted this revision.Nov 6 2018, 19:59
Closed by commit rABCb4460fcaa584: [rpc] Add a unittest for IsDeprecatedRPCEnabled (authored by schancel). · Explain WhyNov 6 2018, 20:00
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
rpc/
2 lines
3 lines
4 lines
test/
3 lines

Diff 5672

View Options

src/Makefile.test.include

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...