Page MenuHomePhabricator
Differential D2079

[qa] fix transaction ordering and padding in abc-p2p-compactblocks.py
ClosedPublic
Actions

Authored by jasonbcox on Nov 17 2018, 19:37.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING5e8bcc09fbbc: [qa] fix transaction ordering and padding in abc-p2p-compactblocks.py
rABC5e8bcc09fbbc: [qa] fix transaction ordering and padding in abc-p2p-compactblocks.py
Summary

Fix abc-p2p-compactblocks.py to support magnetic anomaly upgrade's transaction ordering and padding requirements.

Depends on D2086

Test Plan

test_runner.py abc-p2p-compactblocks

Diff Detail

Repository
rABC Bitcoin ABC
Branch
abc-compactblocks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3930
Build 5932: Bitcoin ABC Buildbot (legacy)
Build 5931: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 17 2018, 19:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2018, 19:37
teamcity added a subscriber: teamcity.Nov 17 2018, 20:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien requested changes to this revision.Nov 17 2018, 20:17
Fabien added inline comments.
test/functional/abc-p2p-compactblocks.py
104

If the block already contains transactions, you should sort all the transactions after you added some to the block.
It works because you also added the sort in the next_block() function, but I think it could lead to errors in the future (i.e. calling the actually unused update_block function).

This revision now requires changes to proceed.Nov 17 2018, 20:17
teamcity added a comment.Nov 17 2018, 20:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3930: Diff 5856!Nov 17 2018, 20:20
jasonbcox updated this revision to Diff 5872.Nov 18 2018, 02:01
jasonbcox marked an inline comment as done.

Fix according to feedback and rebase

teamcity added a comment.Nov 18 2018, 02:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 18 2018, 02:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3944: Diff 5872!Nov 18 2018, 02:07
schancel accepted this revision.Nov 18 2018, 02:46
jasonbcox updated this revision to Diff 5878.Nov 18 2018, 05:39

Fix according to feedback

teamcity added a comment.Nov 18 2018, 05:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added inline comments.Nov 18 2018, 05:46
test/functional/abc-p2p-compactblocks.py
104

Good catch. thank you

teamcity added a comment.Nov 18 2018, 05:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3949: Diff 5878!Nov 18 2018, 05:48
schancel updated this revision to Diff 5882.Nov 18 2018, 09:57

Rebase on D2081

schancel retitled this revision from Fix transaction ordering and padding in abc-p2p-compactblocks.py to [qa] fix transaction ordering and padding in abc-p2p-compactblocks.py.Nov 18 2018, 09:57
schancel edited the summary of this revision. (Show Details)
teamcity added a comment.Nov 18 2018, 09:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 5883.Nov 18 2018, 09:59

Undo a change

teamcity added a comment.Nov 18 2018, 10:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 18 2018, 10:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3953: Diff 5882!Nov 18 2018, 10:05
teamcity added a comment.Nov 18 2018, 10:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3954: Diff 5883!Nov 18 2018, 10:07
schancel edited the summary of this revision. (Show Details)Nov 18 2018, 10:37
schancel added a parent revision: D2081: [qa] restore invalidateblock to it's pre fork behavior.
schancel edited the summary of this revision. (Show Details)
schancel added a parent revision: D2086: [qa] fix abc-p2p-fullblock test to support magnetic anomaly.
schancel removed a parent revision: D2081: [qa] restore invalidateblock to it's pre fork behavior.
jasonbcox updated this revision to Diff 5891.Nov 18 2018, 18:10

Rebased

teamcity added a comment.Nov 18 2018, 18:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox updated this revision to Diff 5892.Nov 18 2018, 18:12

typo

jasonbcox removed a reviewer: Fabien.Nov 18 2018, 18:13
This revision is now accepted and ready to land.Nov 18 2018, 18:13
teamcity added a comment.Nov 18 2018, 18:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 18 2018, 18:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3960: Diff 5891!Nov 18 2018, 18:19
teamcity added a comment.Nov 18 2018, 18:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3961: Diff 5892!Nov 18 2018, 18:21
Closed by commit rABC5e8bcc09fbbc: [qa] fix transaction ordering and padding in abc-p2p-compactblocks.py (authored by jasonbcox). · Explain WhyNov 18 2018, 18:31
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
11 lines

Diff 5856

View Options

test/functional/abc-p2p-compactblocks.py

Loading...