Page MenuHomePhabricator
Differential D2092

[tests] Fix checkinputs_test to work under magnetic anomaly
ClosedPublic
Actions

Authored by schancel on Nov 19 2018, 01:34.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING5a97f9ae4add: [tests] Fix checkinputs_test to work under magnetic anomaly
rABC5a97f9ae4add: [tests] Fix checkinputs_test to work under magnetic anomaly
Summary

As per title. Add CTOR ordering to test block construction. Use NULLDUMMY
instead of CLEANSTACK for checking consensus vs non-consensus script cache behavior.

Test Plan
make -j10 VERBOSE=1 check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fucked-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3973
Build 6018: Bitcoin ABC Buildbot (legacy)
Build 6017: arc lint + arc unit

Event Timeline

schancel updated this revision to Diff 5908.Nov 19 2018, 01:34
schancel created this revision.

Re-remove useless header

teamcity added a subscriber: teamcity.Nov 19 2018, 01:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 5909.Nov 19 2018, 01:36

Fix legacy comment

teamcity added a comment.Nov 19 2018, 01:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 19 2018, 01:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel edited the summary of this revision. (Show Details)Nov 19 2018, 01:38
deadalnix requested changes to this revision.Nov 19 2018, 01:40
deadalnix added a subscriber: deadalnix.

I'm sure I missed some of the feedback provided on D2089 .

src/test/txvalidationcache_tests.cpp
22

Remove

182

Seems like a temporary would be beneficial here

186

Why is that called p2sh if it is not p2sh ?

194

The whole block should be scoped

196

Fix comment

This revision now requires changes to proceed.Nov 19 2018, 01:40
teamcity added a comment.Nov 19 2018, 01:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3973: Diff 5907!Nov 19 2018, 01:44
jasonbcox added a subscriber: jasonbcox.Nov 19 2018, 01:44
jasonbcox added inline comments.
src/test/txvalidationcache_tests.cpp
249

DERSIG -> NULLDUMMY

jasonbcox requested changes to this revision.Nov 19 2018, 01:45
teamcity added a comment.Nov 19 2018, 01:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3974: Diff 5908!Nov 19 2018, 01:46
teamcity added a comment.Nov 19 2018, 01:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3975: Diff 5909!Nov 19 2018, 01:47
schancel updated this revision to Diff 5910.Nov 19 2018, 01:49

Fix feedback

teamcity added a comment.Nov 19 2018, 01:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Nov 19 2018, 01:56
jasonbcox added inline comments.
src/test/txvalidationcache_tests.cpp
187 ↗(On Diff #5910)

nulldummySigHas -> nulldummySigHash (missing an 'h')

196 ↗(On Diff #5910)

Comment should be // Mine the funding transaction into a block

This revision now requires changes to proceed.Nov 19 2018, 01:56
jasonbcox added inline comments.Nov 19 2018, 01:57
src/test/txvalidationcache_tests.cpp
170 ↗(On Diff #5910)

double space after Create

teamcity added a comment.Nov 19 2018, 01:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

schancel updated this revision to Diff 5911.Nov 19 2018, 01:58

Fix comments

Harbormaster failed remote builds in B3976: Diff 5910!Nov 19 2018, 01:58
jasonbcox added inline comments.Nov 19 2018, 01:58
src/test/txvalidationcache_tests.cpp
180 ↗(On Diff #5910)

Scope should start before this line imo. There's no reason to have the mutableFunding_tx stuff inside this scope, right?

teamcity added a comment.Nov 19 2018, 01:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added inline comments.Nov 19 2018, 02:00
src/test/txvalidationcache_tests.cpp
180 ↗(On Diff #5910)

It doesn't change anything. But it groups things logically. Ehter way it is fine.

jasonbcox accepted this revision.Nov 19 2018, 02:01
deadalnix accepted this revision.Nov 19 2018, 02:01
This revision is now accepted and ready to land.Nov 19 2018, 02:01
Closed by commit rABC5a97f9ae4add: [tests] Fix checkinputs_test to work under magnetic anomaly (authored by schancel). · Explain WhyNov 19 2018, 02:06
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Nov 19 2018, 02:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3977: Diff 5911!Nov 19 2018, 02:07

Revision Contents
Changeset List

PathSize
src/
test/
8 lines
68 lines

Diff 5907

View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...