Page MenuHomePhabricator

Fix a few integration tests
ClosedPublic

Authored by deadalnix on Jun 21 2017, 12:36.

Details

Summary

They were broken by the introduction of mandatory limits on the generated block size.

Test Plan

Run the extended test suite.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixtests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 375
Build 375: arc lint + arc unit

Event Timeline

src/init.cpp
1404 ↗(On Diff #599)

The override of this parameter should not take effect for the enclosing condition when nProposedMaxGeneratedBlockSize > config.GetMaxBlockSize() .

I would suggest splitting the condition up into a check <= legacy (with this override) and keep the rejection if > config.GetMaxBlockSize

deadalnix retitled this revision from Fix a few wintegration tests to Fix a few integration tests.Jun 21 2017, 12:53
deadalnix added inline comments.
src/init.cpp
1404 ↗(On Diff #599)

You are correct.

Have allowsmallgeneratedblocksize only bypass the error when the size is too small. Add a test for the behavior.

Additional test case also looks good. Accepting.

src/init.cpp
1404 ↗(On Diff #599)

Modified check looks good to me.

This revision is now accepted and ready to land.Jun 21 2017, 13:15
This revision was automatically updated to reflect the committed changes.