Fix nits in bitcoingui.cpp
ClosedPublic
Actions

Authored by schancel on Nov 27 2018, 18:13.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING407240d4555f: Fix nits in bitcoingui.cpp
rABC407240d4555f: Fix nits in bitcoingui.cpp

Summary

Per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

nits-bitcoingui (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4146
Build 6363: Bitcoin ABC Buildbot (legacy)
Build 6362: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 27 2018, 18:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2018, 18:13

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4146: Diff 6135.Nov 27 2018, 18:24

schancel retitled this revision from fix nits in bitcoingui.cpp to Fix nits in bitcoingui.cpp.Nov 27 2018, 18:26

jasonbcox accepted this revision.Nov 27 2018, 18:27

This revision is now accepted and ready to land.Nov 27 2018, 18:27

Fix more nits

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4150: Diff 6141.Nov 27 2018, 19:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC407240d4555f: Fix nits in bitcoingui.cpp (authored by schancel). · Explain WhyNov 27 2018, 21:24

This revision was automatically updated to reflect the committed changes.

majcosta mentioned this in D6957: [backport#15040] Add workaround for QProgressDialog bug on macOS.Jul 16 2020, 21:42

majcosta mentioned this in rABC93424b164732: [backport#15040] Add workaround for QProgressDialog bug on macOS.Jul 16 2020, 22:47

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.cpp

18 lines

Diff 6135

View Options

Fix nits in bitcoingui.cppClosedPublicActions