Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Summary

Implement a class that returns the median of the feerates in the mempool
currently. Complexity should be O(nlogn) for inserts and constant time for
obtaining the median.

Depends on D2172

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fee-estimation (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4251
Build 6567: Bitcoin ABC Buildbot (legacy)
Build 6566: arc lint + arc unit

Event Timeline

schancel created this revision.Dec 3 2018, 07:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2018, 07:01

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4245: Diff 6251!Dec 3 2018, 07:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4248: Diff 6254!Dec 3 2018, 07:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

schancel updated this revision to Diff 6256.Dec 3 2018, 08:54

schancel marked an inline comment as done.

This comment was removed by schancel.

schancel marked an inline comment as done.Dec 3 2018, 08:55

schancel added inline comments.

src/policy/fees.cpp
68 ↗	(On Diff #6256)	Tests fail without this. However, I can't find any mistake above with respect to the comparator and heap operations.
24 ↗	(On Diff #6254)	Just looking for a concept ACK. Right now I've got something mixed up in the running median logic.