Page MenuHomePhabricator
Differential D2172

[policy] Delete block policy estimator.
ClosedPublic
Actions

Authored by deadalnix on Dec 3 2018, 06:28.

Details

Reviewers
schancel
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING98f245df1538: [policy] Delete block policy estimator.
rABC98f245df1538: [policy] Delete block policy estimator.
Summary

This commit removes the block policy estimator. It's currently basically useless,
and the algorithm for determining minimum fee isn't correct either. We will replace this
estimator using something that examines the active mempool.

Depends on D2037
Complete T499

Test Plan
make VERBOSE=1 check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
delete-fee-estimator (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4252
Build 6569: Bitcoin ABC Buildbot (legacy)
Build 6568: arc lint + arc unit

Event Timeline

schancel created this revision.Dec 3 2018, 06:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2018, 06:28
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 3 2018, 06:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 3 2018, 06:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4241: Diff 6246.Dec 3 2018, 06:40
schancel updated this revision to Diff 6247.Dec 3 2018, 06:43

Remove writing/reading of fee stats.

teamcity added a comment.Dec 3 2018, 06:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4242: Diff 6247!Dec 3 2018, 06:50
teamcity added a comment.Dec 3 2018, 06:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

schancel updated this revision to Diff 6249.Dec 3 2018, 06:52

Remove test_framework dependency on silly file

teamcity added a comment.Dec 3 2018, 06:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 6250.Dec 3 2018, 06:54

Include change to docs

teamcity added a comment.Dec 3 2018, 06:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 3 2018, 07:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel added a child revision: D2173: [WIP] Use mempool for fee estimates, not blocks..Dec 3 2018, 07:01
Harbormaster completed remote builds in B4243: Diff 6249.Dec 3 2018, 07:02
teamcity added a comment.Dec 3 2018, 07:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4244: Diff 6250.Dec 3 2018, 07:04
schancel updated this revision to Diff 6252.Dec 3 2018, 07:05

Clean up some unnecessary globals

teamcity added a comment.Dec 3 2018, 07:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 6253.Dec 3 2018, 07:08

Remove last vestigates of block policy estimator

teamcity added a comment.Dec 3 2018, 07:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 3 2018, 07:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4246: Diff 6252!Dec 3 2018, 07:14
teamcity added a comment.Dec 3 2018, 07:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4247: Diff 6253.Dec 3 2018, 07:18
schancel updated this revision to Diff 6255.Dec 3 2018, 07:22

Remove an extraneous whitespace

teamcity added a comment.Dec 3 2018, 07:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4249: Diff 6255.Dec 3 2018, 07:33
teamcity added a comment.Dec 3 2018, 07:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel updated this revision to Diff 6258.Dec 3 2018, 09:03

Delete yet another vestige

teamcity added a comment.Dec 3 2018, 09:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 3 2018, 09:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4252: Diff 6258.Dec 3 2018, 09:13
deadalnix commandeered this revision.Jan 18 2019, 23:34
deadalnix edited reviewers, added: schancel; removed: deadalnix.
deadalnix updated this revision to Diff 6737.Jan 18 2019, 23:38

Reconstruct the patchset

deadalnix updated this revision to Diff 6739.Jan 19 2019, 00:51

Rebase

teamcity added a comment.Jan 19 2019, 01:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 19 2019, 01:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 19 2019, 01:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 19 2019, 01:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4575: Diff 6739.Jan 19 2019, 01:31
teamcity added a comment.Jan 19 2019, 01:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4573: Diff 6737.Jan 19 2019, 01:36
markblundeberg accepted this revision as: markblundeberg.Jan 26 2019, 05:57
markblundeberg added a subscriber: markblundeberg.

Great idea, code changes look good.

src/policy/fees.h
28 ↗(On Diff #6739)

will it be possible to get rid of this too (and FEE_SPACING above) ?

This revision is now accepted and ready to land.Jan 26 2019, 05:57
deadalnix updated this revision to Diff 6958.Jan 28 2019, 11:42

rebase

teamcity added a comment.Jan 28 2019, 11:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 28 2019, 11:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4719: Diff 6958.Jan 28 2019, 11:58
Closed by commit rABC98f245df1538: [policy] Delete block policy estimator. (authored by deadalnix). · Explain WhyJan 28 2019, 16:50
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGING98f245df1538: [policy] Delete block policy estimator..Sep 18 2019, 22:07
Fabien mentioned this in D13200: Remove dead code in mempool.Feb 28 2023, 16:17
Fabien mentioned this in rABCf25e5123332a: Remove dead code in mempool.Mar 1 2023, 11:04

Revision Contents
Changeset List

PathSize
doc/
1 line
2 lines
src/
25 lines
policy/
248 lines
531 lines
test/
236 lines
7 lines
60 lines
wallet/
1 line
test/
functional/
test_framework/
2 lines

Diff 6258

View Options

doc/files.md

Loading...
View Options

doc/release-notes.md

Loading...
View Options

src/init.cpp

Loading...
View Options

src/policy/fees.h

Loading...
View Options

src/policy/fees.cpp

Loading...
View Options

src/test/policyestimator_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/wallet/fees.h

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...