Differential D2180

[wallet] Clarify wallet initialization / destruction interface
ClosedPublic
Actions

Authored by Fabien on Dec 7 2018, 15:15.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe90de6eb79bc: [wallet] Clarify wallet initialization / destruction interface
rABCe90de6eb79bc: [wallet] Clarify wallet initialization / destruction interface

Summary

All wallet component initialization/destruction functions are now in their own wallet/init.cpp translation unit and are no longer static functions on the CWallet class. The bitcoin_server also no longer has any knowledge that there are multiple wallets in vpwallet.

There should be no changes in behavior from this PR.

Backport of core PR10767

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10767

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4277
Build 6619: Bitcoin ABC Buildbot (legacy)
Build 6618: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 7 2018, 15:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2018, 15:15

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4277: Diff 6293.Dec 7 2018, 15:25

Fabien added a child revision: D2181: [wallet] Remove Wallet dependencies from init.cpp.Dec 7 2018, 15:52

deadalnix accepted this revision.Dec 7 2018, 20:06

This revision is now accepted and ready to land.Dec 7 2018, 20:06

Closed by commit rABCe90de6eb79bc: [wallet] Clarify wallet initialization / destruction interface (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyDec 7 2018, 20:52

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

24 lines

wallet/

26 lines

38 lines

3 lines

4 lines

Diff 6293

src/init.cpp

Loading...

src/wallet/init.h

Loading...

src/wallet/init.cpp

Loading...

src/wallet/rpcwallet.h

Loading...

src/wallet/rpcwallet.cpp

Loading...