Page MenuHomePhabricator
Differential D2189

Remove redundant connect_nodes call in abc-parkedchain.py
ClosedPublic
Actions

Authored by jasonbcox on Dec 13 2018, 01:47.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING570a09320a31: Remove redundant connect_nodes call in abc-parkedchain.py
rABC570a09320a31: Remove redundant connect_nodes call in abc-parkedchain.py
Summary

setup_network does this automatically, so this call is redundant.
Originally, I discovered this while looking for the root cause of this test's
flakiness.

Test Plan

for i in {1..150}; do ./test_runner.py abc-parkedchain; done
Test is still flaky, but passes 99%+ of the time with this change still.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
parkedfix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4350
Build 6765: Bitcoin ABC Buildbot (legacy)
Build 6764: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 13 2018, 01:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2018, 01:47
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 13 2018, 01:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 13 2018, 01:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4307: Diff 6335.Dec 13 2018, 01:58
Fabien requested changes to this revision.Dec 13 2018, 16:06
Fabien added inline comments.
test/functional/abc-parkedchain.py
129 ↗(On Diff #6335)

This should not be needed. I suppose that you want the ensure that node tip and parking_node tip is the same, which is tested below.
This has been discussed with @deadalnix in another diff, and using a dedicated wait_until function seems to be a better way to do this:

def wait_for_tip(node, tip):
    def check_tip():
        return node.getbestblockhash() == tip
    wait_until(check_tip)
        
wait_for_tip(parking_node, good_tip)
This revision now requires changes to proceed.Dec 13 2018, 16:06
jasonbcox updated this revision to Diff 6402.Dec 21 2018, 21:47

Use wait_until according to feedback

teamcity added a comment.Dec 21 2018, 21:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 21 2018, 21:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4350: Diff 6402.Dec 21 2018, 21:58
Fabien accepted this revision.Dec 22 2018, 08:50
This revision is now accepted and ready to land.Dec 22 2018, 08:50
jasonbcox updated this revision to Diff 6429.Dec 28 2018, 03:30

Rebase

teamcity added a comment.Dec 28 2018, 03:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4368: Diff 6429.Dec 28 2018, 03:40
teamcity added a comment.Dec 28 2018, 03:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC570a09320a31: Remove redundant connect_nodes call in abc-parkedchain.py (authored by jasonbcox). · Explain WhyDec 28 2018, 04:06
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
11 lines

Diff 6402

View Options

test/functional/abc-parkedchain.py

Loading...