Page MenuHomePhabricator
Differential D2219

Remove check for thread_local in build systems
ClosedPublic
Actions

Authored by deadalnix on Dec 22 2018, 18:57.

Details

Reviewers
jasonbcox
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING9dde3da1bac9: Remove check for thread_local in build systems
rABC9dde3da1bac9: Remove check for thread_local in build systems
Summary

It is part of C++11, so has become useless to check for.

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
threadlocaltest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4358
Build 6781: Bitcoin ABC Buildbot (legacy)
Build 6780: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 22 2018, 18:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2018, 18:57
Herald added a subscriber: schancel. · View Herald Transcript
Harbormaster failed remote builds in B4358: Diff 6414!Dec 22 2018, 18:57
Fabien mentioned this in D2220: Fix clang warnings.Dec 22 2018, 22:30
Fabien added a subscriber: Fabien.Dec 22 2018, 22:33

LGTM. Tested with make/cmake and gcc/clang.
Can you check why the build has failed ?

Fabien mentioned this in rABC23b1fc5ca89a: Fix clang warnings.Dec 23 2018, 15:36
teamcity added a subscriber: teamcity.Dec 28 2018, 22:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 28 2018, 22:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4358: Diff 6414.Dec 28 2018, 22:48
jasonbcox accepted this revision.Dec 29 2018, 01:10
jasonbcox added a subscriber: jasonbcox.

I reran the build for you. Looks like it was a spurious failure with the build bot, not an issue with the codebase.

This revision is now accepted and ready to land.Dec 29 2018, 01:10
Fabien accepted this revision.Dec 29 2018, 11:54
Closed by commit rABC9dde3da1bac9: Remove check for thread_local in build systems (authored by deadalnix). · Explain WhyDec 30 2018, 11:29
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in rSTAGING23b1fc5ca89a: Fix clang warnings.Jan 20 2019, 23:53
Fabien mentioned this in D5540: Thread names in logs and deadlock debug tools.Mar 23 2020, 15:36
Fabien mentioned this in rABC3372a6e87684: Thread names in logs and deadlock debug tools.Mar 24 2020, 09:39
jasonbcox mentioned this in D5612: Remove Windows 32 bit build.Mar 30 2020, 19:21
Fabien mentioned this in rSTAGING3372a6e87684: Thread names in logs and deadlock debug tools.Apr 7 2020, 23:26
Fabien mentioned this in D8990: [backport#18665] Do not expose and consider -logthreadnames when it does not work.Jan 21 2021, 08:47

Revision Contents
Changeset List

PathSize
22 lines
src/
config/
5 lines
2 lines
4 lines

Diff 6414

View Options

configure.ac

Loading...
View Options

src/config/CMakeLists.txt

Loading...
View Options

src/config/bitcoin-config.h.cmake.in

Loading...
View Options

src/sync.cpp

Loading...